Subject: Re: [PATCH net-next v3] net: stmmac: mmc_core: Drop interrupt registers from stats

From: Jiri Pirko <[email-masked]>
Date: Mon, 26 Feb 2024 10:22:19 +0100

Fri, Feb 23, 2024 at 09:37:01PM CET, [email-masked] wrote:
>The MMC IPC interrupt status and interrupt mask registers are
>of little use as Ethernet statistics, but incrementing counters
>based on the current interrupt and interrupt mask registers
>makes them actively misleading.
>
>For example, if the interrupt mask is set to 0x08420842,
>the current code will increment by that amount each iteration,
>leading to the following sequence of nonsense:
>
>mmc_rx_ipc_intr_mask: 969816526
>mmc_rx_ipc_intr_mask: 1108361744
>
>These registers have been included in the Ethernet statistics
>since the first version of MMC back in 2011 (commit 1c901a46d57).
>That commit also mentions the MMC interrupts as
>"something to add later (if actually useful)".
>
>If the registers are actually useful, they should probably
>be part of the Ethernet register dump instead of statistics,
>but for now, drop the counters for mmc_rx_ipc_intr and
>mmc_rx_ipc_intr_mask completely.
>
>Reviewed-by: Serge Semin <[email-masked]>
>Signed-off-by: Jesper Nilsson <[email-masked]>

Reviewed-by: Jiri Pirko <[email-masked]>

[...]

>---
>base-commit: a08689109c5989acdc5c320de8e45324f6cfa791
>change-id: 20240216-stmmac_stats-e3561d460d0e

Not sure what this is good for...