Subject: Re: [PATCH net] devlink: Fix length of eswitch inline-mode

From: Jiri Pirko <[email-masked]>
Date: Mon, 11 Mar 2024 09:34:44 +0100

Sun, Mar 10, 2024 at 05:45:47PM CET, [email-masked] wrote:
>Set eswitch inline-mode to be u8, not u16. Otherwise, errors below
>
>$ devlink dev eswitch set pci/0000:08:00.0 mode switchdev \
>  inline-mode network
>    Error: Attribute failed policy validation.
>    kernel answers: Numerical result out of rang
>    netlink: 'devlink': attribute type 26 has an invalid length.
>
>Fixes: f2f9dd164db0 ("netlink: specs: devlink: add the remaining command to generate complete split_ops")

Oops. I wonder if I messed anything else.

Reviewed-by: Jiri Pirko <[email-masked]>

Thanks!

>Signed-off-by: William Tu <[email-masked]>
>---
>Or we can fix the iproute2 to use u16?

Nope, this is UAPI.