Subject: Re: [PATCH net-next 3/3] genetlink: remove linux/genetlink.h

From: Andy Shevchenko <[email-masked]>
Date: Mon, 11 Mar 2024 12:00:56 +0200

On Sat, Mar 09, 2024 at 10:34:58AM -0800, Jakub Kicinski wrote:
> genetlink.h is a shell of what used to be a combined uAPI
> and kernel header over a decade ago. It has fewer than
> 10 lines of code. Merge it into net/genetlink.h.
> In some ways it'd be better to keep the combined header
> under linux/ but it would make looking through git history
> harder.

...

> +/* All generic netlink requests are serialized by a global lock.  */
> +extern void genl_lock(void);
> +extern void genl_unlock(void);

Do you need to inherit unneeded 'extern' here?

...

> +#define MODULE_ALIAS_GENL_FAMILY(family) \
> + MODULE_ALIAS_NET_PF_PROTO_NAME(PF_NETLINK, NETLINK_GENERIC, "-family-" family)

This is using the macro defined in net.h which seems not being included.

-- 
With Best Regards,
Andy Shevchenko