From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Kory Maincent <kory.maincent@bootlin•com>
Cc: Jakub Kicinski <kuba@kernel•org>,
Florian Fainelli <florian.fainelli@broadcom•com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom•com>,
Andrew Lunn <andrew@lunn•ch>,
Heiner Kallweit <hkallweit1@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Richard Cochran <richardcochran@gmail•com>,
Radu Pirea <radu-nicolae.pirea@oss•nxp.com>,
Jay Vosburgh <j.vosburgh@gmail•com>,
Andy Gospodarek <andy@greyhouse•net>,
Nicolas Ferre <nicolas.ferre@microchip•com>,
Claudiu Beznea <claudiu.beznea@tuxon•dev>,
Willem de Bruijn <willemdebruijn.kernel@gmail•com>,
Jonathan Corbet <corbet@lwn•net>,
Horatiu Vultur <horatiu.vultur@microchip•com>,
UNGLinuxDriver@microchip•com, Simon Horman <horms@kernel•org>,
Vladimir Oltean <vladimir.oltean@nxp•com>,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-doc@vger•kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin•com>,
Rahul Rameshbabu <rrameshbabu@nvidia•com>,
Alexandra Winter <wintera@linux•ibm.com>
Subject: Re: [PATCH net-next v10 07/13] net: Add struct kernel_ethtool_ts_info
Date: Wed, 10 Apr 2024 20:37:28 +0100 [thread overview]
Message-ID: <ZhbqeCeTHIU0LrIn@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240410155412.2f34a117@kmaincent-XPS-13-7390>
On Wed, Apr 10, 2024 at 03:54:12PM +0200, Kory Maincent wrote:
> On Wed, 10 Apr 2024 11:04:36 +0100
> "Russell King (Oracle)" <linux@armlinux•org.uk> wrote:
>
> > On Wed, Apr 10, 2024 at 10:12:00AM +0200, Kory Maincent wrote:
> > > On Tue, 9 Apr 2024 18:27:25 -0700
> > > Jakub Kicinski <kuba@kernel•org> wrote:
> > >
> > > > On Tue, 09 Apr 2024 10:26:29 +0200 Kory Maincent wrote:
> > > > > In prevision to add new UAPI for hwtstamp we will be limited to the
> > > > > struct ethtool_ts_info that is currently passed in fixed binary format
> > > > > through the ETHTOOL_GET_TS_INFO ethtool ioctl. It would be good if new
> > > > > kernel code already started operating on an extensible kernel variant
> > > > > of that structure, similar in concept to struct kernel_hwtstamp_config
> > > > > vs struct hwtstamp_config.
> > > > >
> > > > > Since struct ethtool_ts_info is in include/uapi/linux/ethtool.h, here
> > > > > we introduce the kernel-only structure in include/linux/ethtool.h.
> > > > > The manual copy is then made in the function called by
> > > > > ETHTOOL_GET_TS_INFO.
> > > >
> > > > This one now conflicts :(
> > > >
> > > > Applying: net: Add struct kernel_ethtool_ts_info
> > > > error: sha1 information is lacking or useless
> > > > (drivers/net/phy/marvell_ptp.c). error: could not build fake ancestor
> > >
> > > gnn patching my out of tree patch in the series! Sorry for that.
> >
> > Given that this path corresponds to the driver I wrote, do I assume
> > that you've picked up my work on PTP support for Marvell PHYs? You
> > should be aware that I still have the patches out of tree but it's
> > been pointless me reposting it until the issue of which PTP gets
> > used has been solved. (Publishing will just increase the pressure
> > to merge it without the PTP problems being solved, and thus break
> > Marvell PP2 PTP.)
>
> Yes I did with few fixes and I know you don't want to post the patches until
> setting which PTP gets used has been solved. As you can see this is one of the
> subject of this series. About it, could you review this series? This would help
> a lot and you will be able to post again your Marvell PTP patches if its get
> merged.
I wish I could, but I'm seriously short of available time at the
moment. I'm fitting in what I can day by day and there are many
things wanting my attention - but I don't have enough time at the
moment for everything. So really I can't take on anything new
right now.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-04-10 19:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 8:26 [PATCH net-next v10 00/13] net: Make timestamping selectable Kory Maincent
2024-04-09 8:26 ` [PATCH net-next v10 01/13] net_tstamp: Add TIMESTAMPING SOFTWARE and HARDWARE mask Kory Maincent
2024-04-09 8:26 ` [PATCH net-next v10 02/13] net: Move dev_set_hwtstamp_phylib to net/core/dev.h Kory Maincent
2024-04-09 14:43 ` Willem de Bruijn
2024-04-09 8:26 ` [PATCH net-next v10 03/13] net: Make dev_get_hwtstamp_phylib accessible Kory Maincent
2024-04-09 8:26 ` [PATCH net-next v10 04/13] net: Make net_hwtstamp_validate accessible Kory Maincent
2024-04-09 8:26 ` [PATCH net-next v10 05/13] net: Change the API of PHY default timestamp to MAC Kory Maincent
2024-04-09 8:26 ` [PATCH net-next v10 06/13] net: net_tstamp: Add unspec field to hwtstamp_source enumeration Kory Maincent
2024-04-09 8:26 ` [PATCH net-next v10 07/13] net: Add struct kernel_ethtool_ts_info Kory Maincent
2024-04-10 1:27 ` Jakub Kicinski
2024-04-10 8:12 ` Kory Maincent
2024-04-10 10:04 ` Russell King (Oracle)
2024-04-10 13:54 ` Kory Maincent
2024-04-10 19:37 ` Russell King (Oracle) [this message]
2024-04-09 8:26 ` [PATCH net-next v10 08/13] ptp: Add phc source and helpers to register specific PTP clock or get information Kory Maincent
2024-04-11 3:00 ` Willem de Bruijn
2024-04-11 3:18 ` Willem de Bruijn
2024-04-14 5:33 ` Kory Maincent
2024-04-14 16:33 ` Willem de Bruijn
2024-04-09 8:26 ` [PATCH net-next v10 09/13] net: Add the possibility to support a selected hwtstamp in netdevice Kory Maincent
2024-04-09 8:26 ` [PATCH net-next v10 10/13] net: netdevsim: ptp_mock: Convert to netdev_ptp_clock_register Kory Maincent
2024-04-09 8:26 ` [PATCH net-next v10 11/13] net: macb: " Kory Maincent
2024-04-09 8:26 ` [PATCH net-next v10 12/13] net: ethtool: tsinfo: Add support for hwtstamp provider and get/set hwtstamp config Kory Maincent
2024-04-09 8:26 ` [PATCH net-next v10 13/13] netlink: specs: tsinfo: Enhance netlink attributes and add a set command Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZhbqeCeTHIU0LrIn@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=andy@greyhouse$(echo .)net \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=claudiu.beznea@tuxon$(echo .)dev \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=horatiu.vultur@microchip$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@microchip$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=radu-nicolae.pirea@oss$(echo .)nxp.com \
--cc=richardcochran@gmail$(echo .)com \
--cc=rrameshbabu@nvidia$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
--cc=wintera@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox