From: Sabrina Dubroca <sd@queasysnail•net>
To: j.granados@samsung•com
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Alexander Aring <alex.aring@gmail•com>,
Stefan Schmidt <stefan@datenfreihafen•org>,
Miquel Raynal <miquel.raynal@bootlin•com>,
David Ahern <dsahern@kernel•org>,
Steffen Klassert <steffen.klassert@secunet•com>,
Herbert Xu <herbert@gondor•apana.org.au>,
Matthieu Baerts <matttbe@kernel•org>,
Mat Martineau <martineau@kernel•org>,
Geliang Tang <geliang@kernel•org>,
Remi Denis-Courmont <courmisch@gmail•com>,
Allison Henderson <allison.henderson@oracle•com>,
David Howells <dhowells@redhat•com>,
Marc Dionne <marc.dionne@auristor•com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail•com>,
Xin Long <lucien.xin@gmail•com>,
Wenjia Zhang <wenjia@linux•ibm.com>,
Jan Karcher <jaka@linux•ibm.com>,
"D. Wythe" <alibuda@linux•alibaba.com>,
Tony Lu <tonylu@linux•alibaba.com>,
Wen Gu <guwen@linux•alibaba.com>,
Trond Myklebust <trond.myklebust@hammerspace•com>,
Anna Schumaker <anna@kernel•org>,
Chuck Lever <chuck.lever@oracle•com>,
Jeff Layton <jlayton@kernel•org>, Neil Brown <neilb@suse•de>,
Olga Kornievskaia <kolga@netapp•com>,
Dai Ngo <Dai.Ngo@oracle•com>, Tom Talpey <tom@talpey•com>,
Jon Maloy <jmaloy@redhat•com>, Ying Xue <ying.xue@windriver•com>,
Martin Schiller <ms@dev•tdt.de>,
Pablo Neira Ayuso <pablo@netfilter•org>,
Jozsef Kadlecsik <kadlec@netfilter•org>,
Florian Westphal <fw@strlen•de>, Roopa Prabhu <roopa@nvidia•com>,
Nikolay Aleksandrov <razor@blackwall•org>,
Simon Horman <horms@verge•net.au>, Julian Anastasov <ja@ssi•bg>,
Joerg Reuter <jreuter@yaina•de>,
Luis Chamberlain <mcgrof@kernel•org>,
Kees Cook <keescook@chromium•org>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
dccp@vger•kernel.org, linux-wpan@vger•kernel.org,
mptcp@lists•linux.dev, linux-hams@vger•kernel.org,
linux-rdma@vger•kernel.org, rds-devel@oss•oracle.com,
linux-afs@lists•infradead.org, linux-sctp@vger•kernel.org,
linux-s390@vger•kernel.org, linux-nfs@vger•kernel.org,
tipc-discussion@lists•sourceforge.net, linux-x25@vger•kernel.org,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
bridge@lists•linux.dev, lvs-devel@vger•kernel.org
Subject: Re: [PATCH v5 1/8] net: Remove the now superfluous sentinel elements from ctl_table array
Date: Mon, 29 Apr 2024 10:53:47 +0200 [thread overview]
Message-ID: <Zi9gG82_OKnLlFI2@hog> (raw)
In-Reply-To: <20240426-jag-sysctl_remset_net-v5-1-e3b12f6111a6@samsung.com>
2024-04-26, 12:46:53 +0200, Joel Granados via B4 Relay wrote:
> diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
> index 6973dda3abda..a84690b13bb9 100644
> --- a/net/core/sysctl_net_core.c
> +++ b/net/core/sysctl_net_core.c
[...]
> @@ -723,12 +722,11 @@ static __net_init int sysctl_core_net_init(struct net *net)
> if (tbl == NULL)
> goto err_dup;
>
> - for (tmp = tbl; tmp->procname; tmp++)
> - tmp->data += (char *)net - (char *)&init_net;
Some coding style nits in case you re-post:
> + for (int i = 0; i < table_size; ++i)
move the declaration of int i out of the for (), it's almost never
written this way (at least in networking)
> + (tbl + i)->data += (char *)net - (char *)&init_net;
tbl[i].data = ...
is more in line with other similar functions in the rest of net/
[...]
> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
> index 6dab883a08dd..ecc849678e7b 100644
> --- a/net/mpls/af_mpls.c
> +++ b/net/mpls/af_mpls.c
[...]
> @@ -2674,6 +2673,7 @@ static const struct ctl_table mpls_table[] = {
>
> static int mpls_net_init(struct net *net)
> {
> + size_t table_size = ARRAY_SIZE(mpls_table);
This table still has a {} as its final element. It should be gone too?
--
Sabrina
next prev parent reply other threads:[~2024-04-29 8:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 10:46 [PATCH v5 0/8] sysctl: Remove sentinel elements from networking Joel Granados via B4 Relay
2024-04-26 10:46 ` [PATCH v5 1/8] net: Remove the now superfluous sentinel elements from ctl_table array Joel Granados via B4 Relay
2024-04-29 8:53 ` Sabrina Dubroca [this message]
2024-04-29 12:33 ` Joel Granados
2024-04-29 14:49 ` Sabrina Dubroca
2024-04-30 12:41 ` Joel Granados
2024-04-26 10:46 ` [PATCH v5 2/8] net: ipv{6,4}: " Joel Granados via B4 Relay
2024-04-26 10:46 ` [PATCH v5 3/8] net: rds: " Joel Granados via B4 Relay
2024-04-26 10:46 ` [PATCH v5 4/8] net: sunrpc: " Joel Granados via B4 Relay
2024-04-26 12:26 ` Jeffrey Layton
2024-04-26 12:58 ` Chuck Lever
2024-04-26 10:46 ` [PATCH v5 5/8] net: Remove ctl_table sentinel elements from several networking subsystems Joel Granados via B4 Relay
2024-04-26 15:13 ` Sabrina Dubroca
2024-04-29 9:10 ` Joel Granados
2024-04-26 10:46 ` [PATCH v5 6/8] netfilter: Remove the now superfluous sentinel elements from ctl_table array Joel Granados via B4 Relay
2024-04-26 12:09 ` Julian Anastasov
2024-04-29 9:32 ` Joel Granados
2024-04-26 10:46 ` [PATCH v5 7/8] appletalk: " Joel Granados via B4 Relay
2024-04-26 10:47 ` [PATCH v5 8/8] ax.25: x.25: " Joel Granados via B4 Relay
2024-04-27 8:14 ` Sabrina Dubroca
2024-04-29 10:05 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zi9gG82_OKnLlFI2@hog \
--to=sd@queasysnail$(echo .)net \
--cc=Dai.Ngo@oracle$(echo .)com \
--cc=alex.aring@gmail$(echo .)com \
--cc=alibuda@linux$(echo .)alibaba.com \
--cc=allison.henderson@oracle$(echo .)com \
--cc=anna@kernel$(echo .)org \
--cc=bridge@lists$(echo .)linux.dev \
--cc=chuck.lever@oracle$(echo .)com \
--cc=coreteam@netfilter$(echo .)org \
--cc=courmisch@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dccp@vger$(echo .)kernel.org \
--cc=dhowells@redhat$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=geliang@kernel$(echo .)org \
--cc=guwen@linux$(echo .)alibaba.com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=horms@verge$(echo .)net.au \
--cc=j.granados@samsung$(echo .)com \
--cc=ja@ssi$(echo .)bg \
--cc=jaka@linux$(echo .)ibm.com \
--cc=jlayton@kernel$(echo .)org \
--cc=jmaloy@redhat$(echo .)com \
--cc=jreuter@yaina$(echo .)de \
--cc=kadlec@netfilter$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=kolga@netapp$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-afs@lists$(echo .)infradead.org \
--cc=linux-hams@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=linux-wpan@vger$(echo .)kernel.org \
--cc=linux-x25@vger$(echo .)kernel.org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=lvs-devel@vger$(echo .)kernel.org \
--cc=marc.dionne@auristor$(echo .)com \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=martineau@kernel$(echo .)org \
--cc=matttbe@kernel$(echo .)org \
--cc=mcgrof@kernel$(echo .)org \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=mptcp@lists$(echo .)linux.dev \
--cc=ms@dev$(echo .)tdt.de \
--cc=neilb@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=razor@blackwall$(echo .)org \
--cc=rds-devel@oss$(echo .)oracle.com \
--cc=roopa@nvidia$(echo .)com \
--cc=stefan@datenfreihafen$(echo .)org \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=tom@talpey$(echo .)com \
--cc=tonylu@linux$(echo .)alibaba.com \
--cc=trond.myklebust@hammerspace$(echo .)com \
--cc=wenjia@linux$(echo .)ibm.com \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox