From: Jiri Pirko <jiri@resnulli•us>
To: Michal Swiatkowski <michal.swiatkowski@linux•intel.com>
Cc: intel-wired-lan@lists•osuosl.org, netdev@vger•kernel.org,
jacob.e.keller@intel•com, michal.kubiak@intel•com,
maciej.fijalkowski@intel•com, sridhar.samudrala@intel•com,
przemyslaw.kitszel@intel•com, wojciech.drewek@intel•com,
pio.raczynski@gmail•com, jiri@nvidia•com,
mateusz.polchlopek@intel•com
Subject: Re: [iwl-next v4 5/8] ice: allocate devlink for subfunction
Date: Thu, 18 Apr 2024 19:25:35 +0200 [thread overview]
Message-ID: <ZiFXj-58u2shLL3g@nanopsycho> (raw)
In-Reply-To: <ZiFGOkSMWs+/N2vI@mev-dev>
Thu, Apr 18, 2024 at 06:11:38PM CEST, michal.swiatkowski@linux•intel.com wrote:
>On Thu, Apr 18, 2024 at 05:43:25PM +0200, Jiri Pirko wrote:
>> Thu, Apr 18, 2024 at 04:46:23PM CEST, michal.swiatkowski@linux•intel.com wrote:
>> >On Thu, Apr 18, 2024 at 03:02:49PM +0200, Jiri Pirko wrote:
>> >> Thu, Apr 18, 2024 at 02:48:53PM CEST, michal.swiatkowski@linux•intel.com wrote:
>> >> >On Thu, Apr 18, 2024 at 02:04:21PM +0200, Jiri Pirko wrote:
>> >> >> Wed, Apr 17, 2024 at 04:20:25PM CEST, michal.swiatkowski@linux•intel.com wrote:
>> >> >> >From: Piotr Raczynski <piotr.raczynski@intel•com>
>> >> >>
>> >> >> [...]
>> >> >>
>> >> >> >+/**
>> >> >> >+ * ice_allocate_sf - Allocate devlink and return SF structure pointer
>> >> >> >+ * @dev: the device to allocate for
>> >> >> >+ *
>> >> >> >+ * Allocate a devlink instance for SF.
>> >> >> >+ *
>> >> >> >+ * Return: void pointer to allocated memory
>> >> >> >+ */
>> >> >> >+struct ice_sf_priv *ice_allocate_sf(struct device *dev)
>> >> >>
>> >> >> This is devlink instance for SF auxdev. Please make sure it is properly
>> >> >> linked with the devlink port instance using devl_port_fn_devlink_set()
>> >> >> See mlx5 implementation for inspiration.
>> >> >>
>> >> >>
>> >> >
>> >> >I am going to do it in the last patchset. I know that it isn't the best
>> >>
>> >> Where? Either I'm blind or you don't do it.
>> >>
>> >>
>> >
>> >You told me to split few patches from first patchset [1]. We agree that
>> >there will be too many patches for one submission, so I split it into
>> >3:
>> >- 1/3 devlink prework (already accepted)
>> >- 2/3 base subfunction (this patchset)
>> >- 3/3 port representor refactor to support subfunction (I am going to
>> > include it there)
>>
>> Sorry, but how is this relevant to my suggestion to use
>> devl_port_fn_devlink_set() which you apparently don't?
>>
>
>Devlink port to link with is introduced in the port representor part.
>Strange, but it fitted to my splitting. I can move
>activation/deactivation part also to this patchset (as there is no
>devlink port to call it on) if you want.
You have 7 more patches to use in this set. No problem. Please do it all
at once.
>
>>
>> >
>> >[1] https://lore.kernel.org/netdev/20240301115414.502097-1-michal.swiatkowski@linux.intel.com/
>> >
>> >Thanks,
>> >Michal
>> >
>> >> >option to split patchesets like that, but it was hard to do it differently.
>> >> >
>> >> >Thanks,
>> >> >Michal
>> >> >
>> >> >> >+{
>> >> >> >+ return ice_devlink_alloc(dev, sizeof(struct ice_sf_priv),
>> >> >> >+ &ice_sf_devlink_ops);
>> >> >> >+}
>> >> >> >+
>> >> >>
>> >> >> [...]
next prev parent reply other threads:[~2024-04-18 17:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 14:20 [iwl-next v4 0/8] ice: support devlink subfunction Michal Swiatkowski
2024-04-17 14:20 ` [iwl-next v4 1/8] ice: add new VSI type for subfunctions Michal Swiatkowski
2024-04-17 14:20 ` [iwl-next v4 2/8] ice: export ice ndo_ops functions Michal Swiatkowski
2024-04-17 14:20 ` [iwl-next v4 3/8] ice: add basic devlink subfunctions support Michal Swiatkowski
2024-04-17 14:20 ` [iwl-next v4 4/8] ice: treat subfunction VSI the same as PF VSI Michal Swiatkowski
2024-04-17 14:20 ` [iwl-next v4 5/8] ice: allocate devlink for subfunction Michal Swiatkowski
2024-04-18 12:04 ` Jiri Pirko
2024-04-18 12:48 ` Michal Swiatkowski
2024-04-18 13:02 ` Jiri Pirko
2024-04-18 14:46 ` Michal Swiatkowski
2024-04-18 15:43 ` Jiri Pirko
2024-04-18 16:11 ` Michal Swiatkowski
2024-04-18 17:25 ` Jiri Pirko [this message]
2024-04-19 17:22 ` Michal Swiatkowski
2024-04-17 14:20 ` [iwl-next v4 6/8] ice: base subfunction aux driver Michal Swiatkowski
2024-04-18 7:57 ` Shay Drori
2024-04-18 14:47 ` Michal Swiatkowski
2024-04-18 13:02 ` Jiri Pirko
2024-04-18 14:47 ` Michal Swiatkowski
2024-04-17 14:20 ` [iwl-next v4 7/8] ice: implement netdev for subfunction Michal Swiatkowski
2024-04-17 14:20 ` [iwl-next v4 8/8] ice: allow to activate and deactivate subfunction Michal Swiatkowski
[not found] ` <0045c1a5-1065-40b3-ae61-1f372d4a89e5@nvidia.com>
2024-04-18 8:12 ` Shay Drori
2024-04-18 11:55 ` Michal Swiatkowski
2024-04-18 12:20 ` Shay Drori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiFXj-58u2shLL3g@nanopsycho \
--to=jiri@resnulli$(echo .)us \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=maciej.fijalkowski@intel$(echo .)com \
--cc=mateusz.polchlopek@intel$(echo .)com \
--cc=michal.kubiak@intel$(echo .)com \
--cc=michal.swiatkowski@linux$(echo .)intel.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pio.raczynski@gmail$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=wojciech.drewek@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox