Subject: Re: [patch net-next v5 3/5] selftests: forwarding: add check_driver() helper

From: Benjamin Poirier <[email-masked]>
Date: Mon, 22 Apr 2024 14:47:39 -0400

On 2024-04-22 17:32 +0200, Jiri Pirko wrote:
> From: Jiri Pirko <[email-masked]>
> 
> Add a helper to be used to check if the netdevice is backed by specified
> driver.
> 
> Signed-off-by: Jiri Pirko <[email-masked]>
> Reviewed-by: Petr Machata <[email-masked]>
> ---
>  tools/testing/selftests/net/forwarding/lib.sh | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
> index 9d6802c6c023..00e089dd951d 100644
> --- a/tools/testing/selftests/net/forwarding/lib.sh
> +++ b/tools/testing/selftests/net/forwarding/lib.sh
> @@ -278,10 +278,17 @@ check_port_mab_support()
>  	fi
>  }
>  
> -if [[ "$(id -u)" -ne 0 ]]; then
> -	echo "SKIP: need root privileges"
> -	exit $ksft_skip
> -fi

Why is the check being removed entirely? This change was not in v4 of
this patch. Did it happen unintentionally when removing "selftests:
forwarding: move initial root check to the beginning"?

> +check_driver()
> +{
> +	local dev=$1; shift
> +	local expected=$1; shift
> +	local driver_name=`driver_name_get $dev`
> +
> +	if [[ $driver_name != $expected ]]; then
> +		echo "SKIP: expected driver $expected for $dev, got $driver_name instead"
> +		exit $ksft_skip
> +	fi
> +}
>  
>  if [[ "$CHECK_TC" = "yes" ]]; then
>  	check_tc_version
> -- 
> 2.44.0
> 
>