From: Breno Leitao <leitao@debian•org>
To: Eric Dumazet <edumazet@google•com>
Cc: Florian Westphal <fw@strlen•de>,
netdev@vger•kernel.org, Paolo Abeni <pabeni@redhat•com>,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>
Subject: Re: [PATCH net-next] ip6_vti: fix memleak on netns dismantle
Date: Wed, 24 Apr 2024 08:11:27 -0700 [thread overview]
Message-ID: <ZikhH7gY/cvGaVJO@gmail.com> (raw)
In-Reply-To: <CANn89iJQZd8EPv+uXp4=+fbp4gMxa9d2CDdqmE3LwXV9makaZg@mail.gmail.com>
Hello Eric,
On Tue, Apr 23, 2024 at 09:53:45PM +0200, Eric Dumazet wrote:
> On Tue, Apr 23, 2024 at 11:46 AM Breno Leitao <leitao@debian•org> wrote:
> >
> > Hello Florian,
> >
> > On Mon, Apr 15, 2024 at 02:23:44PM +0200, Florian Westphal wrote:
> > > kmemleak reports net_device resources are no longer released, restore
> > > needs_free_netdev toggle. Sample backtrace:
> > >
> > > unreferenced object 0xffff88810874f000 (size 4096): [..]
> > > [<00000000a2b8af8b>] __kmalloc_node+0x209/0x290
> > > [<0000000040b0a1a9>] alloc_netdev_mqs+0x58/0x470
> > > [<00000000b4be1e78>] vti6_init_net+0x94/0x230
> > > [<000000008830c1ea>] ops_init+0x32/0xc0
> > > [<000000006a26fa8f>] setup_net+0x134/0x2e0
> > > [..]
> > >
> > > Cc: Breno Leitao <leitao@debian•org>
> > > Fixes: a9b2d55a8f1e ("ip6_vti: Do not use custom stat allocator")
> > > Signed-off-by: Florian Westphal <fw@strlen•de>
> > > ---
> > > net/ipv6/ip6_vti.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c
> > > index 4d68a0777b0c..78344cf3867e 100644
> > > --- a/net/ipv6/ip6_vti.c
> > > +++ b/net/ipv6/ip6_vti.c
> > > @@ -901,6 +901,7 @@ static void vti6_dev_setup(struct net_device *dev)
> > > {
> > > dev->netdev_ops = &vti6_netdev_ops;
> > > dev->header_ops = &ip_tunnel_header_ops;
> > > + dev->needs_free_netdev = true;
> >
> > Thanks for the fix!
> >
> > Could you help me to understand how needs_free_netdev will trigger the
> > free()here?
> >
> > I _though_ that any device that is being unregistered would have the stats
> > freed.
> >
> > This is the flow I am reading:
> >
> > 1) When the device is unregistered, then it is marked as todo:
> >
> > unregister_netdevice_many_notify() {
> > list_for_each_entry(dev, head, unreg_list) {
> > net_set_todo(dev);
> > }
> > }
> >
> > 2) Then, "run_todo" will run later, and it does:
> > netdev_run_todo() {
> > list_for_each_entry_safe(dev, tmp, &list, todo_list) {
> > if (unlikely(dev->reg_state != NETREG_UNREGISTERING)) {
> > netdev_WARN(dev, "run_todo but not unregistering\n");
> > list_del(&dev->todo_list);
> > continue;
> > }
> >
> > while (!list_empty(&list)) {
> > netdev_do_free_pcpu_stats(dev);
>
> The relevant part is missing:
>
> if (dev->needs_free_netdev)
> free_netdev(dev);
>
> > }
> >
> > }
> >
> > Thank you!
>
> I do not think Florian patch has anything to do with free_pcpu_stats()
That makes total sense now.
I though the memory that was being leaked was related to pcpu stats,
since this is was I was supposedly changing, but, it is not.
The regression is not related to the fact that
a9b2d55a8f1e ("ip6_vti: Do not use custom stat allocator") removed
the following line wrongly:
-dev->needs_free_netdev = true;
Everything is clear now.
Thanks!
prev parent reply other threads:[~2024-04-24 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 12:23 [PATCH net-next] ip6_vti: fix memleak on netns dismantle Florian Westphal
2024-04-16 14:03 ` Simon Horman
2024-04-17 0:40 ` patchwork-bot+netdevbpf
2024-04-23 9:46 ` Breno Leitao
2024-04-23 19:53 ` Eric Dumazet
2024-04-24 15:11 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZikhH7gY/cvGaVJO@gmail.com \
--to=leitao@debian$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox