Subject: Re: [PATCH net-next v6 2/7] net: stmmac: Add dedicated XPCS cleanup method

From: "Russell King (Oracle)" <[email-masked]>
Date: Fri, 10 May 2024 16:52:03 +0100

On Fri, May 10, 2024 at 09:38:09AM +0200, Romain Gantois wrote:
> From: Serge Semin <[email-masked]>
> 
> Currently the XPCS handler destruction is performed in the
> stmmac_mdio_unregister() method. It doesn't look good because the handler
> isn't originally created in the corresponding protagonist
> stmmac_mdio_unregister(), but in the stmmac_xpcs_setup() function. In
> order to have more coherent MDIO and XPCS setup/cleanup procedures,
> let's move the DW XPCS destruction to the dedicated stmmac_pcs_clean()
> method.
> 
> This method will also be used to cleanup PCS hardware using the
> pcs_exit() callback that will be introduced to stmmac in a subsequent
> patch.
> 
> Signed-off-by: Serge Semin <[email-masked]>
> Co-developed-by: Romain Gantois <[email-masked]>

Reviewed-by: Russell King (Oracle) <[email-masked]>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!