public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Xiaolei Wang <xiaolei.wang@windriver•com>
Cc: alexandre.torgue@foss•st.com, joabreu@synopsys•com,
	davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
	pabeni@redhat•com, mcoquelin.stm32@gmail•com,
	richardcochran@gmail•com, bartosz.golaszewski@linaro•org,
	horms@kernel•org, ahalaney@redhat•com, rohan.g.thomas@intel•com,
	j.zink@pengutronix•de, leong.ching.swee@intel•com,
	netdev@vger•kernel.org, linux-stm32@st-md-mailman•stormreply.com,
	linux-arm-kernel@lists•infradead.org,
	linux-kernel@vger•kernel.org
Subject: Re: [PATCH v3] net: stmmac: move the lock to struct plat_stmmacenet_data
Date: Wed, 8 May 2024 09:11:37 +0100	[thread overview]
Message-ID: <ZjszuWWw8PPxNyKE@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240508045257.2470698-1-xiaolei.wang@windriver.com>

On Wed, May 08, 2024 at 12:52:57PM +0800, Xiaolei Wang wrote:
> Reinitialize the whole est structure would also reset the mutex lock
> which is embedded in the est structure, and then trigger the following
> warning. To address this, move the lock to struct plat_stmmacenet_data.
> We also need to require the mutex lock when doing this initialization.

What is plat->lock protecting exactly? "lock" is opaque and doesn't
hint at its purpose. Does it serialise accesses to plat->est? If so,
consider naming it plat->est_lock to make its purpose and what it's
doing clear.

Please also follow netdev best practice; allow at least 24 hours to
pass _and_ for discussion to finish before posting a new version of
a patch or patch series.

Also see the "How do I indicate which tree" question at:
https://www.kernel.org/doc/html/v5.3/networking/netdev-FAQ.html

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

next prev parent reply	other threads:[~2024-05-08  8:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08  4:52 [PATCH v3] net: stmmac: move the lock to struct plat_stmmacenet_data Xiaolei Wang
2024-05-08  8:11 ` Russell King (Oracle) [this message]
2024-05-08  9:56 ` Serge Semin
2024-05-09  1:10   ` wang xiaolei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjszuWWw8PPxNyKE@shell.armlinux.org.uk \
    --to=linux@armlinux$(echo .)org.uk \
    --cc=ahalaney@redhat$(echo .)com \
    --cc=alexandre.torgue@foss$(echo .)st.com \
    --cc=bartosz.golaszewski@linaro$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=horms@kernel$(echo .)org \
    --cc=j.zink@pengutronix$(echo .)de \
    --cc=joabreu@synopsys$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=leong.ching.swee@intel$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
    --cc=mcoquelin.stm32@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=richardcochran@gmail$(echo .)com \
    --cc=rohan.g.thomas@intel$(echo .)com \
    --cc=xiaolei.wang@windriver$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox