Subject: Re: [PATCH net-next] netconsole: Do not shutdown dynamic configuration if cmdline is invalid

From: Breno Leitao <[email-masked]>
Date: Tue, 14 May 2024 05:06:26 -0700

On Mon, May 13, 2024 at 02:51:29PM -0700, Jakub Kicinski wrote:
> On Fri, 10 May 2024 03:30:05 -0700 Breno Leitao wrote:
> > +static inline bool dynamic_netconsole_enabled(void)
> > +{
> > +	return IS_ENABLED(CONFIG_NETCONSOLE_DYNAMIC);
> > +}
> 
> Why the separate static inline?

I thought it would make the code easier to read.

> We can put IS_ENABLED.. directly in the if condition.

Sure. I will send a v2 with the IS_ENABLED() inside the if condition.

Thanks for the review.