From: Tony Lu <tonylu@linux•alibaba.com>
To: Kevin Yang <yyd@google•com>
Cc: David Miller <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next 0/2] tcp: add sysctl_tcp_rto_min_us
Date: Wed, 29 May 2024 15:21:31 +0800 [thread overview]
Message-ID: <ZlbXeytf4RkAI40N@TONYMAC-ALIBABA.local> (raw)
In-Reply-To: <20240528171320.1332292-1-yyd@google.com>
On Tue, May 28, 2024 at 05:13:18PM +0000, Kevin Yang wrote:
> Adding a sysctl knob to allow user to specify a default
> rto_min at socket init time.
>
> After this patch series, the rto_min will has multiple sources:
> route option has the highest precedence, followed by the
> TCP_BPF_RTO_MIN socket option, followed by this new
> tcp_rto_min_us sysctl.
For series:
Reviewed-by: Tony Lu <tonylu@linux•alibaba.com>
I strongly support those patches. For those who use cgroup v1 and want
to take effect with simple settings, sysctl is a good way.
And reducing it is helpful for latency-sensitive applications such as
Redis, net namespace level sysctl knob is enough.
>
> Kevin Yang (2):
> tcp: derive delack_max with tcp_rto_min helper
> tcp: add sysctl_tcp_rto_min_us
>
> Documentation/networking/ip-sysctl.rst | 13 +++++++++++++
> include/net/netns/ipv4.h | 1 +
> net/ipv4/sysctl_net_ipv4.c | 8 ++++++++
> net/ipv4/tcp.c | 3 ++-
> net/ipv4/tcp_ipv4.c | 1 +
> net/ipv4/tcp_output.c | 11 ++---------
> 6 files changed, 27 insertions(+), 10 deletions(-)
>
> --
> 2.45.1.288.g0e0cd299f1-goog
>
next prev parent reply other threads:[~2024-05-29 7:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 17:13 [PATCH net-next 0/2] tcp: add sysctl_tcp_rto_min_us Kevin Yang
2024-05-28 17:13 ` [PATCH net-next 1/2] tcp: derive delack_max with tcp_rto_min helper Kevin Yang
2024-05-28 17:13 ` [PATCH net-next 2/2] tcp: add sysctl_tcp_rto_min_us Kevin Yang
2024-05-29 23:47 ` Jakub Kicinski
2024-05-29 6:43 ` [PATCH net-next 0/2] " Jason Xing
2024-05-29 6:59 ` Jason Xing
2024-05-29 7:39 ` Eric Dumazet
2024-05-29 7:56 ` Tony Lu
2024-05-29 8:43 ` Jason Xing
2024-05-29 9:23 ` Eric Dumazet
2024-05-29 9:30 ` Jason Xing
2024-05-29 19:56 ` Kevin Yang
2024-05-29 7:21 ` Tony Lu [this message]
2024-05-29 8:49 ` Jason Xing
2024-05-30 1:08 ` Tony Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlbXeytf4RkAI40N@TONYMAC-ALIBABA.local \
--to=tonylu@linux$(echo .)alibaba.com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yyd@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox