From: Hangbin Liu <liuhangbin@gmail•com>
To: Lukasz Majewski <lukma@denx•de>
Cc: Jakub Kicinski <kuba@kernel•org>,
netdev@vger•kernel.org, Paolo Abeni <pabeni@redhat•com>,
Eric Dumazet <edumazet@google•com>,
Vladimir Oltean <olteanv@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Oleksij Rempel <o.rempel@pengutronix•de>,
Tristram.Ha@microchip•com,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
Ravi Gunasekaran <r-gunasekaran@ti•com>,
Simon Horman <horms@kernel•org>,
Nikita Zhandarovich <n.zhandarovich@fintech•ru>,
Murali Karicheri <m-karicheri2@ti•com>,
Arvid Brodin <Arvid.Brodin@xdin•com>,
Dan Carpenter <dan.carpenter@linaro•org>,
"Ricardo B. Marliere" <ricardo@marliere•net>,
Casper Andersson <casper.casan@gmail•com>,
linux-kernel@vger•kernel.org, linux-kselftest@vger•kernel.org,
Geliang Tang <tanggeliang@kylinos•cn>,
Shuah Khan <shuah@kernel•org>
Subject: Re: [PATCH] selftests: hsr: Extend the hsr_redbox.sh test to use fixed MAC addresses
Date: Thu, 30 May 2024 09:34:16 +0800 [thread overview]
Message-ID: <ZlfXmDN-W1dZRYQL@Laptop-X1> (raw)
In-Reply-To: <20240529142232.2625747-2-lukma@denx.de>
On Wed, May 29, 2024 at 04:22:32PM +0200, Lukasz Majewski wrote:
> Fixed MAC addresses help with debugging as last four bytes identify the
> network namespace.
>
> Moreover, it allows to mimic the real life setup with for example bridge
> having the same MAC address on each port.
>
> Signed-off-by: Lukasz Majewski <lukma@denx•de>
> ---
> tools/testing/selftests/net/hsr/hsr_redbox.sh | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/tools/testing/selftests/net/hsr/hsr_redbox.sh b/tools/testing/selftests/net/hsr/hsr_redbox.sh
> index 1f36785347c0..998103502d5d 100755
> --- a/tools/testing/selftests/net/hsr/hsr_redbox.sh
> +++ b/tools/testing/selftests/net/hsr/hsr_redbox.sh
> @@ -96,6 +96,21 @@ setup_hsr_interfaces()
> ip -n "${ns4}" link set ns4eth1 up
> ip -n "${ns5}" link set ns5eth1 up
>
> + ip -net "$ns1" link set address 00:11:22:00:01:01 dev ns1eth1
> + ip -net "$ns1" link set address 00:11:22:00:01:02 dev ns1eth2
> +
> + ip -net "$ns2" link set address 00:11:22:00:02:01 dev ns2eth1
> + ip -net "$ns2" link set address 00:11:22:00:02:02 dev ns2eth2
> + ip -net "$ns2" link set address 00:11:22:00:02:03 dev ns2eth3
> +
> + ip -net "$ns3" link set address 00:11:22:00:03:11 dev ns3eth1
> + ip -net "$ns3" link set address 00:11:22:00:03:11 dev ns3eth2
> + ip -net "$ns3" link set address 00:11:22:00:03:11 dev ns3eth3
> + ip -net "$ns3" link set address 00:11:22:00:03:11 dev ns3br1
The ns3's mac addresses are same, is it a copy-paste error?
BTW, please add the target tree for the patch, e.g.
[PATCH net-next]
Thanks
Hangbin
next prev parent reply other threads:[~2024-05-30 1:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 14:22 [PATCH] selftests: hsr: Extend the hsr_ping.sh test to use fixed MAC addresses Lukasz Majewski
2024-05-29 14:22 ` [PATCH] selftests: hsr: Extend the hsr_redbox.sh " Lukasz Majewski
2024-05-30 1:34 ` Hangbin Liu [this message]
2024-06-03 7:03 ` Lukasz Majewski
2024-06-03 9:32 ` Hangbin Liu
2024-06-03 9:31 ` [PATCH] selftests: hsr: Extend the hsr_ping.sh " Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlfXmDN-W1dZRYQL@Laptop-X1 \
--to=liuhangbin@gmail$(echo .)com \
--cc=Arvid.Brodin@xdin$(echo .)com \
--cc=Tristram.Ha@microchip$(echo .)com \
--cc=bigeasy@linutronix$(echo .)de \
--cc=casper.casan@gmail$(echo .)com \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=lukma@denx$(echo .)de \
--cc=m-karicheri2@ti$(echo .)com \
--cc=n.zhandarovich@fintech$(echo .)ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=o.rempel@pengutronix$(echo .)de \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=r-gunasekaran@ti$(echo .)com \
--cc=ricardo@marliere$(echo .)net \
--cc=shuah@kernel$(echo .)org \
--cc=tanggeliang@kylinos$(echo .)cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox