From: Breno Leitao <leitao@debian•org>
To: Kalle Valo <kvalo@kernel•org>
Cc: linux-wireless@vger•kernel.org, Felix Fietkau <nbd@nbd•name>,
Lorenzo Bianconi <lorenzo@kernel•org>,
Ryder Lee <ryder.lee@mediatek•com>,
Shayne Chen <shayne.chen@mediatek•com>,
Sean Wang <sean.wang@mediatek•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora•com>,
netdev@vger•kernel.org, horms@kernel•org, kees@kernel•org,
kuba@kernel•org, Bo Jiao <Bo.Jiao@mediatek•com>,
Daniel Golle <daniel@makrotopia•org>,
Alexander Couzens <lynxis@fe80•eu>,
Deren Wu <deren.wu@mediatek•com>,
Ming Yen Hsieh <mingyen.hsieh@mediatek•com>,
Leon Yen <leon.yen@mediatek•com>,
Quan Zhou <quan.zhou@mediatek•com>, Ingo Rohloff <lundril@gmx•de>,
Sujuan Chen <sujuan.chen@mediatek•com>,
StanleyYP Wang <StanleyYP.Wang@mediatek•com>,
Benjamin Lin <benjamin-jw.lin@mediatek•com>,
Peter Chiu <chui-hao.chiu@mediatek•com>,
"open list:ARM/Mediatek SoC support"
<linux-kernel@vger•kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists•infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists•infradead.org>
Subject: Re: [PATCH] wifi: mt76: un-embedd netdev from mt76_dev
Date: Mon, 17 Jun 2024 02:22:23 -0700 [thread overview]
Message-ID: <ZnAAT/a3DKnTgUoz@gmail.com> (raw)
In-Reply-To: <87cyogkkju.fsf@kernel.org>
Hello Kalle,
On Mon, Jun 17, 2024 at 12:03:49PM +0300, Kalle Valo wrote:
> Breno Leitao <leitao@debian•org> writes:
>
> > Embedding net_device into structures prohibits the usage of flexible
> > arrays in the net_device structure. For more details, see the discussion
> > at [1].
> >
> > Un-embed the net_devices from struct mt76_dev by converting them
> > into pointers, and allocating them dynamically. Use the leverage
> > alloc_netdev_dummy() to allocate the net_device object at
> > mt76_dma_init().
> >
> > The free of the device occurs at mt76_dma_cleanup().
> >
> > Link: https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/ [1]
> > Signed-off-by: Breno Leitao <leitao@debian•org>
> > ---
> >
> > PS: Due to the lack of hardware, this patch was not tested on a real
> > hardware, unfortunately.
> >
> > PS2: this is the last driver that is still using embedded netdevices.
>
> Is this patch a dependency to other patches? I'm asking because it will
> be _slow_ to get this patch to net-next via wireless trees. If there's
> urgency then it's much better to take it directly to net-next (of course
> with acks from Felix and Lorenzo).
Since this is the last patch for the whole flexible netdev work, I would
prefer to have it through net-next then, so, we finish the whole work
sooner rather than later.
I will prepare a v2 with Simon's suggestion, and I can target net-next.
I am just waiting a bit more to hear from Felix and Lorenzo.
Thanks!
next prev parent reply other threads:[~2024-06-17 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 11:52 [PATCH] wifi: mt76: un-embedd netdev from mt76_dev Breno Leitao
2024-06-16 8:35 ` Simon Horman
2024-06-17 9:03 ` Kalle Valo
2024-06-17 9:22 ` Breno Leitao [this message]
2024-06-17 9:29 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnAAT/a3DKnTgUoz@gmail.com \
--to=leitao@debian$(echo .)org \
--cc=Bo.Jiao@mediatek$(echo .)com \
--cc=StanleyYP.Wang@mediatek$(echo .)com \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=benjamin-jw.lin@mediatek$(echo .)com \
--cc=chui-hao.chiu@mediatek$(echo .)com \
--cc=daniel@makrotopia$(echo .)org \
--cc=deren.wu@mediatek$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kees@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=leon.yen@mediatek$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=lorenzo@kernel$(echo .)org \
--cc=lundril@gmx$(echo .)de \
--cc=lynxis@fe80$(echo .)eu \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mingyen.hsieh@mediatek$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=quan.zhou@mediatek$(echo .)com \
--cc=ryder.lee@mediatek$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=shayne.chen@mediatek$(echo .)com \
--cc=sujuan.chen@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox