Subject: Re: [PATCH net 2/3] mlxsw: core_thermal: Fix driver initialization failure

From: Ido Schimmel <[email-masked]>
Date: Tue, 18 Jun 2024 09:55:51 +0300

On Mon, Jun 17, 2024 at 09:53:59PM +0200, Wysocki, Rafael J wrote:
> On 6/17/2024 6:56 PM, Petr Machata wrote:
> > From: Ido Schimmel <[email-masked]>
> > 
> > Commit 31a0fa0019b0 ("thermal/debugfs: Pass cooling device state to
> > thermal_debug_cdev_add()") changed the thermal core to read the current
> > state of the cooling device as part of the cooling device's
> > registration. This is incompatible with the current implementation of
> > the cooling device operations in mlxsw, leading to initialization
> > failure with errors such as:
> > 
> > mlxsw_spectrum 0000:01:00.0: Failed to register cooling device
> > mlxsw_spectrum 0000:01:00.0: cannot register bus device
> 
> Is this still a problem after
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=thermal&id=1af89dedc8a58006d8e385b1e0d2cd24df8a3b69
> 
> which has been merged into 6.10-rc4?

No, cooling device registration does not fail after your patch.

However, I think it's still worth merging my patch since without it the
driver does not provide a valid initial state which should not happen.

Are you OK with us dropping this patch from v2 and targeting it instead
at net-next (with an updated commit message)?

Thanks