Subject: Re: [PATCH net-next v7 5/5] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988

From: "Russell King (Oracle)" <[email-masked]>
Date: Wed, 19 Jun 2024 21:09:50 +0100

On Wed, Jun 19, 2024 at 11:44:32AM +0000, SkyLake Huang (黃啟澤) wrote:
> On Wed, 2024-06-19 at 10:09 +0100, Russell King (Oracle) wrote:
> >  	 
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
> >  On Thu, Jun 13, 2024 at 06:40:23PM +0800, Sky Huang wrote:
> > > +static struct phy_driver mtk_gephy_driver[] = {
> > > +{
> > > +PHY_ID_MATCH_MODEL(MTK_2P5GPHY_ID_MT7988),
> > > +.name= "MediaTek MT7988 2.5GbE PHY",
> > > +.probe= mt798x_2p5ge_phy_probe,
> > > +.config_init= mt798x_2p5ge_phy_config_init,
> > > +.config_aneg    = mt798x_2p5ge_phy_config_aneg,
> > > +.get_features= mt798x_2p5ge_phy_get_features,
> > > +.read_status= mt798x_2p5ge_phy_read_status,
> > > +.get_rate_matching= mt798x_2p5ge_phy_get_rate_matching,
> > > +.suspend= genphy_suspend,
> > > +.resume= genphy_resume,
> > > +.read_page= mtk_phy_read_page,
> > > +.write_page= mtk_phy_write_page,
> > > +.led_blink_set= mt798x_2p5ge_phy_led_blink_set,
> > > +.led_brightness_set = mt798x_2p5ge_phy_led_brightness_set,
> > > +.led_hw_is_supported = mt798x_2p5ge_phy_led_hw_is_supported,
> > > +.led_hw_control_get = mt798x_2p5ge_phy_led_hw_control_get,
> > > +.led_hw_control_set = mt798x_2p5ge_phy_led_hw_control_set,
> > 
> > I don't see the point of trying to align some of these method
> > declarators but not others. Consistency is important.
> > 
> Sorry I don't get your point on this. What do you mean by "trying to
> align some of these method declarators but not others"? Do you mean
> "mt798x_2p5ge_phy" prefix?

Some of the method initialisers are:

	.foo<tab>= method_foo,
	.bar<tab>= method_bar,
	...

while other are:

	.longlongname<space>= methodlonglongname,

So what this causes is:

	.foo	= method_foo,
	.bar	= method_bar,
	.longlongbaz = methodlonglongbaz,

which looks messy - why use tabs for the short ones and a space for
the others. Why not be consistent, e.g.:

	.foo = method_foo,
	.bar = method_bar,
	.longlongbaz = methodlonglongbaz,

?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!