From: "Günther Noack" <gnoack@google•com>
To: Tahera Fahimi <fahimitahera@gmail•com>
Cc: mic@digikod•net, paul@paul-moore•com, jmorris@namei•org,
serge@hallyn•com, linux-security-module@vger•kernel.org,
linux-kernel@vger•kernel.org, bjorn3_gh@protonmail•com,
jannh@google•com, outreachy@lists•linux.dev,
netdev@vger•kernel.org
Subject: Re: [PATCH v1 2/2] Landlock: Signal scoping tests
Date: Tue, 9 Jul 2024 17:18:57 +0200 [thread overview]
Message-ID: <Zo1U4dX-kGcm0hHA@google.com> (raw)
In-Reply-To: <70756a7b4ed5bd32f2d881aa1a0d1e7760ce4215.1720213293.git.fahimitahera@gmail.com>
On Fri, Jul 05, 2024 at 03:21:43PM -0600, Tahera Fahimi wrote:
> Signed-off-by: Tahera Fahimi <fahimitahera@gmail•com>
> ---
> .../testing/selftests/landlock/ptrace_test.c | 216 ++++++++++++++++++
> 1 file changed, 216 insertions(+)
>
> diff --git a/tools/testing/selftests/landlock/ptrace_test.c b/tools/testing/selftests/landlock/ptrace_test.c
> index a19db4d0b3bd..e092b67f8b67 100644
> --- a/tools/testing/selftests/landlock/ptrace_test.c
> +++ b/tools/testing/selftests/landlock/ptrace_test.c
> [...]
> +static void scope_signal_handler(int sig, siginfo_t *info, void *ucontext)
> +{
> + if (sig == SIGHUP || sig == SIGURG || sig == SIGTSTP || sig == SIGTRAP)
> + signaled = 1;
> +
> + // signal process group
> + //kill(-(t->pid), SIGKILL);
There is commented-out code like this in various places in this patch.
I am pretty sure that scripts/checkpatch.pl should flag that.
See https://docs.kernel.org/dev-tools/checkpatch.html
and https://docs.kernel.org/process/submitting-patches.html#style-check-your-changes
I personally just keep a checklist of things to remember before sending a patch.
(rebase as needed, clang-format -i (for Landlock files), run tests, check commit
metadata, git format-patch with -v and --cover-letter, scripts/checkpatch.pl,
edit cover letter, git send-email)
—Günther
next prev parent reply other threads:[~2024-07-09 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 21:21 [PATCH v1 1/2] Landlock: Add signal control Tahera Fahimi
2024-07-05 21:21 ` [PATCH v1 2/2] Landlock: Signal scoping tests Tahera Fahimi
2024-07-09 15:18 ` Günther Noack [this message]
2024-07-22 12:45 ` [PATCH v1 1/2] Landlock: Add signal control Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo1U4dX-kGcm0hHA@google.com \
--to=gnoack@google$(echo .)com \
--cc=bjorn3_gh@protonmail$(echo .)com \
--cc=fahimitahera@gmail$(echo .)com \
--cc=jannh@google$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-security-module@vger$(echo .)kernel.org \
--cc=mic@digikod$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=outreachy@lists$(echo .)linux.dev \
--cc=paul@paul-moore$(echo .)com \
--cc=serge@hallyn$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox