From: Lorenzo Bianconi <lorenzo@kernel•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: netdev@vger•kernel.org, nbd@nbd•name,
lorenzo.bianconi83@gmail•com, davem@davemloft•net,
edumazet@google•com, pabeni@redhat•com, conor@kernel•org,
linux-arm-kernel@lists•infradead.org, robh+dt@kernel•org,
krzysztof.kozlowski+dt@linaro•org, conor+dt@kernel•org,
devicetree@vger•kernel.org, catalin.marinas@arm•com,
will@kernel•org, upstream@airoha•com,
angelogioacchino.delregno@collabora•com,
benjamin.larsson@genexis•eu, rkannoth@marvell•com,
sgoutham@marvell•com, andrew@lunn•ch, arnd@arndb•de,
horms@kernel•org
Subject: Re: [PATCH v7 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC
Date: Fri, 12 Jul 2024 17:04:34 +0200 [thread overview]
Message-ID: <ZpFGAqM9p-1mGLhM@lore-desk> (raw)
In-Reply-To: <20240712080002.37c11d02@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2010 bytes --]
> On Fri, 12 Jul 2024 16:43:58 +0200 Lorenzo Bianconi wrote:
> > > On Fri, 12 Jul 2024 15:47:38 +0200 Lorenzo Bianconi wrote:
> > > > The Airoha eth SoC architecture is similar to mtk_eth_soc one (e.g MT7988a).
> > > > The FrameEngine (FE) module has multiple GDM ports that are connected to
> > > > different blocks. Current airoha_eth driver supports just GDM1 that is connected
> > > > to a MT7530 DSA switch (I have not posted a tiny patch for mt7530 driver yet).
> > > > In the future we will support even GDM{2,3,4} that will connect to differ
> > > > phy modues (e.g. 2.5Gbps phy).
> > >
> > > What I'm confused by is the mentioned of DSA. You put the port in the
> > > descriptor, and there can only be one switch on the other side, right?
> >
> > do you mean fport in msg1 (airoha_dev_xmit())?
> >
> > fport = port->id == 4 ? FE_PSE_PORT_GDM4 : port->id;
> > msg1 = FIELD_PREP(QDMA_ETH_TXMSG_FPORT_MASK, fport) |
> > ...
> >
> > fport refers to the GDM port and not to the dsa user port. Am I missing
> > something?
>
> Ooh, I see, reading what you explained previously now makes sense.
> So only 1 of the ports goes to the DSA switch, and the other ones
> are connected to SoC pins? A diagram would be worth a 1000 words ;)
exactly, just GDM1 FE port is connected to the DSA switch.
I will try to do my best for the diagram :)
>
> > > be in a setup like this :( It will have no way to figure out the real
> > > egress rate given that each netdev only sees a (non-)random sample
> > > of traffic sharing the queue :(
> >
> > do you prefer to remove BQL support?
>
> No strong preference, I worry it will do more harm than good in
> this case. It's not what it's designed for basically. But without
> testing it's all speculation, so up to you, users can always disable
> using sysfs.
let me take a look to it again but, if it is not harmful, I would prefer
to remove it and add it in the future if necessary.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-07-12 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 8:47 [PATCH v7 net-next 0/2] Introduce EN7581 ethernet support Lorenzo Bianconi
2024-07-10 8:47 ` [PATCH v7 net-next 1/2] dt-bindings: net: airoha: Add EN7581 ethernet controller Lorenzo Bianconi
2024-07-10 8:47 ` [PATCH v7 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC Lorenzo Bianconi
2024-07-12 1:10 ` Jakub Kicinski
2024-07-12 13:47 ` Lorenzo Bianconi
2024-07-12 14:28 ` Jakub Kicinski
2024-07-12 14:43 ` Lorenzo Bianconi
2024-07-12 15:00 ` Jakub Kicinski
2024-07-12 15:04 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpFGAqM9p-1mGLhM@lore-desk \
--to=lorenzo@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=benjamin.larsson@genexis$(echo .)eu \
--cc=catalin.marinas@arm$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=conor@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=lorenzo.bianconi83@gmail$(echo .)com \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rkannoth@marvell$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sgoutham@marvell$(echo .)com \
--cc=upstream@airoha$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox