From: Mina Almasry <almasrymina@google•com>
To: Tom Herbert <tom@herbertland•com>
Cc: davem@davemloft•net, kuba@kernel•org, jesse.brandeburg@intel•com,
anthony.l.nguyen@intel•com, cai.huoqing@linux•dev,
netdev@vger•kernel.org, felipe@sipanda•io
Subject: Re: [RFC net-next 01/10] skbuff: Rename csum_not_inet to csum_is_crc32
Date: Tue, 23 Jul 2024 16:23:15 +0000 [thread overview]
Message-ID: <Zp_Y87B-0yp9Tl3w@google.com> (raw)
In-Reply-To: <20240703224850.1226697-2-tom@herbertland.com>
On Wed, Jul 03, 2024 at 03:48:41PM -0700, Tom Herbert wrote:
> csum_not_inet really refers to SCTP or FCOE CRC. Rename
> to be more precise
>
> Signed-off-by: Tom Herbert <tom@herbertland•com>
I checked that you haven't missed any instances of csum_not_inet unmodified.
The rename seems straightforward and unobjectionable given that the description
of the csum_not_inet field said that it was a crc32 anway.
The previous name also contained an awkward negation. Removing that seems like
an improvement.
FWIW,
Reviewed-by: Mina Almasry <almasrymina@google•com>
next prev parent reply other threads:[~2024-07-23 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 22:48 [RFC net-next 00/10] crc-offload: Split RX CRC offload from csum offload Tom Herbert
2024-07-03 22:48 ` [RFC net-next 01/10] skbuff: Rename csum_not_inet to csum_is_crc32 Tom Herbert
2024-07-23 16:23 ` Mina Almasry [this message]
2024-07-03 22:48 ` [RFC net-next 02/10] skbuff: Add csum_valid_crc32 flag Tom Herbert
2024-07-03 22:48 ` [RFC net-next 03/10] sctp: Call skb_csum_crc32_unnecessary Tom Herbert
2024-07-03 22:48 ` [RFC net-next 04/10] fcoe: " Tom Herbert
2024-07-03 22:48 ` [RFC net-next 05/10] cavium_thunder: Call skb_set_csum_crc32_unnecessary Tom Herbert
2024-07-03 22:48 ` [RFC net-next 06/10] gve: " Tom Herbert
2024-07-03 22:48 ` [RFC net-next 07/10] hisilicon: " Tom Herbert
2024-07-03 22:48 ` [RFC net-next 08/10] idpf: " Tom Herbert
2024-07-03 22:48 ` [RFC net-next 09/10] ixgbe: " Tom Herbert
2024-07-03 22:48 ` [RFC net-next 10/10] wangxun: " Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp_Y87B-0yp9Tl3w@google.com \
--to=almasrymina@google$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=cai.huoqing@linux$(echo .)dev \
--cc=davem@davemloft$(echo .)net \
--cc=felipe@sipanda$(echo .)io \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox