Subject: Re: [RFC net-next 01/10] skbuff: Rename csum_not_inet to csum_is_crc32

From: Mina Almasry <[email-masked]>
Date: Tue, 23 Jul 2024 16:23:15 +0000

On Wed, Jul 03, 2024 at 03:48:41PM -0700, Tom Herbert wrote:
> csum_not_inet really refers to SCTP or FCOE CRC. Rename
> to be more precise
>
> Signed-off-by: Tom Herbert <[email-masked]>

I checked that you haven't missed any instances of csum_not_inet unmodified.

The rename seems straightforward and unobjectionable given that the description
of the csum_not_inet field said that it was a crc32 anway.

The previous name also contained an awkward negation. Removing that seems like
an improvement.

FWIW,

Reviewed-by: Mina Almasry <[email-masked]>