From: Breno Leitao <leitao@debian•org>
To: Dragos Tatulea <dtatulea@nvidia•com>
Cc: Tariq Toukan <tariqt@nvidia•com>,
Saeed Mahameed <saeedm@nvidia•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: mlx5e warnings on 6.10
Date: Thu, 18 Jul 2024 12:12:42 -0700 [thread overview]
Message-ID: <ZplpKq8FKi3vwfxv@gmail.com> (raw)
In-Reply-To: <dad86bed4c22fcedbd280b4a5a5ad8e8298419a5.camel@nvidia.com>
On Thu, Jul 18, 2024 at 11:00:00AM +0000, Dragos Tatulea wrote:
> Hi Breno,
>
> On Wed, 2024-07-17 at 04:41 -0700, Breno Leitao wrote:
> > Sharing in case you find it useful.
> Thanks for the report. The output, it is very useful. The problem seems to be
> that mlx5e_tx_reporter_timeout_recover() should take a state lock and doesn't.
Right. I've looked at other cases where mlx5e_safe_reopen_channels() is
called, and priv->state_lock is, in fact, hold before calling it.
So, independent if this fix the problem or not, it seems the right thing
to do.
Feel free to add a "Reviewed-by: Breno Leitao <leitao@debian•org>" when
you send it.
> I wonder why this happened only in 6.10. There were no relevant changes in 6.10.
> Or is it maybe that until now you didn't run into the tx queue timeout issue?
I don't have a reproducer for it, so, i just got it in 6.10. Maybe just
a coincidence?
> Would you have the possibility and willingness to test the below fix?
Sure. I have two hosts running with your patch, but, it is hard to make
them timeout.
Let me know if you have any trick I can explore and force the card to
time out.
Thanks for the quick reply!
--breno
next prev parent reply other threads:[~2024-07-18 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 11:41 mlx5e warnings on 6.10 Breno Leitao
2024-07-18 11:00 ` Dragos Tatulea
2024-07-18 19:12 ` Breno Leitao [this message]
2024-07-19 16:57 ` Dragos Tatulea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZplpKq8FKi3vwfxv@gmail.com \
--to=leitao@debian$(echo .)org \
--cc=dtatulea@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeedm@nvidia$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox