From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Javier Carrasco <javier.carrasco.cruz@gmail•com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
"Rafael J. Wysocki" <rafael@kernel•org>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Jonathan Cameron <jic23@kernel•org>,
Rob Herring <robh@kernel•org>,
Daniel Scally <djrscally@gmail•com>,
Heikki Krogerus <heikki.krogerus@linux•intel.com>,
Sakari Ailus <sakari.ailus@linux•intel.com>,
Jean Delvare <jdelvare@suse•com>,
Guenter Roeck <linux@roeck-us•net>, Pavel Machek <pavel@ucw•cz>,
Lee Jones <lee@kernel•org>,
Marcin Wojtas <marcin.s.wojtas@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
linux-acpi@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-hwmon@vger•kernel.org, linux-leds@vger•kernel.org,
netdev@vger•kernel.org
Subject: Re: [PATCH 6/6] net: mvpp2: use device_for_each_child_node() to access device child nodes
Date: Mon, 29 Jul 2024 14:00:36 +0100 [thread overview]
Message-ID: <ZqeSdMMOk+GbVzHj@shell.armlinux.org.uk> (raw)
In-Reply-To: <aa440f7c-0ccc-443c-8435-50c864edd1c2@gmail.com>
On Mon, Jul 29, 2024 at 11:23:47AM +0200, Javier Carrasco wrote:
> Apart from that, there is a suspicious check towards the end of the same
> function:
>
> if (is_acpi_node(port_fwnode))
> return;
>
> At the point it is called in the current implementation, port_fwnode
> could have been cleaned. And after removing the loop, it is simply
> uninitialized. Was that meant to be pdev->dev->fwnode?
If you're referring to the one before the clk_disable_unprepare() calls,
it's only slightly suspicious:
These clocks are setup in a:
if (dev_of_node(&pdev->dev)) {
...
}
block, so they're only setup if we have device tree. So, avoiding it
for ACPI is entirely reasonable. However, we also have software nodes
as well, so the test should be:
if (!dev_of_node(&pdev->dev))
return;
to match what the probe function is doing.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2024-07-29 13:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-06 15:23 [PATCH 0/6] use device_for_each_child_node() to access device child nodes Javier Carrasco
2024-07-06 15:23 ` [PATCH 1/6] device property: document device_for_each_child_node macro Javier Carrasco
2024-07-07 16:53 ` Jonathan Cameron
2024-07-06 15:23 ` [PATCH 2/6] hwmon: (ltc2992) use device_for_each_child_node_scoped() to access child nodes Javier Carrasco
2024-07-07 16:55 ` Jonathan Cameron
2024-07-06 15:23 ` [PATCH 3/6] leds: bd2606mvv: use device_for_each_child_node() to access device " Javier Carrasco
2024-07-07 16:57 ` Jonathan Cameron
2024-07-08 8:14 ` Javier Carrasco
2024-07-08 8:28 ` Jonathan Cameron
2024-07-08 15:45 ` Javier Carrasco
2024-07-12 21:06 ` Andreas Kemnade
2024-07-13 21:37 ` Javier Carrasco
2024-07-06 15:23 ` [PATCH 4/6] leds: is31fl319x: use device_for_each_child_node_scoped() to access " Javier Carrasco
2024-07-07 16:58 ` Jonathan Cameron
2024-07-06 15:23 ` [PATCH 5/6] leds: pca995x: use device_for_each_child_node() to access device " Javier Carrasco
2024-07-07 16:59 ` Jonathan Cameron
2024-07-06 15:23 ` [PATCH 6/6] net: mvpp2: " Javier Carrasco
2024-07-07 17:01 ` Jonathan Cameron
2024-07-29 8:23 ` Russell King (Oracle)
2024-07-29 9:23 ` Javier Carrasco
2024-07-29 13:00 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqeSdMMOk+GbVzHj@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=djrscally@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=heikki.krogerus@linux$(echo .)intel.com \
--cc=javier.carrasco.cruz@gmail$(echo .)com \
--cc=jdelvare@suse$(echo .)com \
--cc=jic23@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-hwmon@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=marcin.s.wojtas@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=rafael@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=sakari.ailus@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox