Subject: Re: [PATCH net 1/2] ionic: Fix napi case where budget == 0

From: Joe Damato <[email-masked]>
Date: Wed, 14 Aug 2024 12:33:20 +0100

On Tue, Aug 13, 2024 at 04:41:21PM -0700, Brett Creeley wrote:
> The change in the fixes allowed the ionic_tx_cq_service() function
> to be called when budget == 0, but no packet completions will
> actually be serviced since it returns immediately when budget is
> passed in as 0. Fix this by not checking budget before entering
> the completion servicing while loop. This will allow a single
> cq entry to be processed since ++work_done will always be greater
> than work_to_do.
> 
> With this change a simple netconsole test as described in
> Documentation/networking/netconsole.txt works as expected.
> 
> Fixes: 2f74258d997c ("ionic: minimal work with 0 budget")
> Signed-off-by: Brett Creeley <[email-masked]>
> ---
>  drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 3 ---
>  1 file changed, 3 deletions(-)

I think fixes may need to CC stable, but in either case:

Reviewed-by: Joe Damato <[email-masked]>