Subject: Re: [PATCH] netfilter: remove unnecessary assignment in translate_table

From: Pablo Neira Ayuso <[email-masked]>
Date: Mon, 19 Aug 2024 19:02:09 +0200

On Mon, Jul 01, 2024 at 07:53:02PM +0800, Liu Jing wrote:
> in translate_table, the initialized value of 'ret' is unused,
> because it will be assigned in the rear. thus remove it.
> 
> Signed-off-by: Liu Jing <[email-masked]>
> ---
>  net/ipv4/netfilter/ip_tables.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c
> index fe89a056eb06..c9b34d7d7558 100644
> --- a/net/ipv4/netfilter/ip_tables.c
> +++ b/net/ipv4/netfilter/ip_tables.c
> @@ -664,7 +664,7 @@ translate_table(struct net *net, struct xt_table_info *newinfo, void *entry0,
>  	struct ipt_entry *iter;
>  	unsigned int *offsets;
>  	unsigned int i;
> -	int ret = 0;
> +	int ret;

ip6_tables is a copy&paste from ip_tables, so it is arp_tables.

I think all of them have the same unnecessary initialization.

Would you still post v2?