From: Andy Shevchenko <andy@kernel•org>
To: Philipp Stanner <pstanner@redhat•com>
Cc: "onathan Corbet" <corbet@lwn•net>, "Jens Axboe" <axboe@kernel•dk>,
"Wu Hao" <hao.wu@intel•com>, "Tom Rix" <trix@redhat•com>,
"Moritz Fischer" <mdf@kernel•org>,
"Xu Yilun" <yilun.xu@intel•com>,
"Linus Walleij" <linus.walleij@linaro•org>,
"Bartosz Golaszewski" <brgl@bgdev•pl>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Alexandre Torgue" <alexandre.torgue@foss•st.com>,
"Jose Abreu" <joabreu@synopsys•com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail•com>,
"Bjorn Helgaas" <bhelgaas@google•com>,
"Alvaro Karsz" <alvaro.karsz@solid-run•com>,
"Michael S. Tsirkin" <mst@redhat•com>,
"Jason Wang" <jasowang@redhat•com>,
"Xuan Zhuo" <xuanzhuo@linux•alibaba.com>,
"Eugenio Pérez" <eperezma@redhat•com>,
"Richard Cochran" <richardcochran@gmail•com>,
"Mark Brown" <broonie@kernel•org>,
"David Lechner" <dlechner@baylibre•com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>,
"Jonathan Cameron" <Jonathan.Cameron@huawei•com>,
"Hannes Reinecke" <hare@suse•de>,
"Damien Le Moal" <dlemoal@kernel•org>,
"Chaitanya Kulkarni" <kch@nvidia•com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
linux-doc@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-block@vger•kernel.org, linux-fpga@vger•kernel.org,
linux-gpio@vger•kernel.org, netdev@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, linux-pci@vger•kernel.org,
virtualization@lists•linux.dev
Subject: Re: [PATCH 7/9] ethernet: stmicro: Simplify PCI devres usage
Date: Mon, 19 Aug 2024 21:28:42 +0300 [thread overview]
Message-ID: <ZsOO2uuGmD97Mocj@smile.fi.intel.com> (raw)
In-Reply-To: <20240819165148.58201-9-pstanner@redhat.com>
On Mon, Aug 19, 2024 at 06:51:47PM +0200, Philipp Stanner wrote:
> stmicro uses PCI devres in the wrong way. Resources requested
> through pcim_* functions don't need to be cleaned up manually in the
> remove() callback or in the error unwind path of a probe() function.
>
> Moreover, there is an unnecessary loop which only requests and ioremaps
> BAR 0, but iterates over all BARs nevertheless.
>
> Furthermore, pcim_iomap_regions() and pcim_iomap_table() have been
> deprecated by the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
> pcim_iomap_table(), pcim_iomap_regions_request_all()").
>
> Replace these functions with pcim_iomap_region().
>
> Remove the unnecessary manual pcim_* cleanup calls.
>
> Remove the unnecessary loop over all BARs.
...
loongson_dwmac_probe()
> + memset(&res, 0, sizeof(res));
> + res.addr = pcim_iomap_region(pdev, 0, pci_name(pdev));
> + if (IS_ERR(res.addr)) {
> + ret = PTR_ERR(res.addr);
> + goto err_disable_device;
It seems your series reveals issues in the error paths of .probe():s
in many drivers...
If we use pcim variant to enable device, why do we need to explicitly
disable it?
> }
...
loongson_dwmac_remove()
> pci_disable_msi(pdev);
> pci_disable_device(pdev);
Not sure why we need these either...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-19 18:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 16:51 [PATCH 0/9] PCI: Remove pcim_iounmap_regions() Philipp Stanner
2024-08-19 16:51 ` [PATCH 1/9] PCI: Make pcim_release_region() a public function Philipp Stanner
2024-08-19 23:07 ` Damien Le Moal
2024-08-19 16:51 ` [PATCH 2/9] PCI: Make pcim_iounmap_region() " Philipp Stanner
2024-08-19 23:08 ` Damien Le Moal
2024-08-19 16:51 ` [PATCH 3/9] fpga/dfl-pci.c: Replace deprecated PCI functions Philipp Stanner
2024-08-19 16:51 ` [PATCH 4/9] block: mtip32xx: " Philipp Stanner
2024-08-19 18:04 ` Andy Shevchenko
2024-08-20 7:29 ` Philipp Stanner
2024-08-20 10:28 ` Andy Shevchenko
2024-08-20 7:22 ` Philipp Stanner
2024-08-19 16:51 ` [PATCH 5/9] gpio: " Philipp Stanner
2024-08-19 18:22 ` Andy Shevchenko
2024-08-19 18:39 ` Bartosz Golaszewski
2024-08-19 16:51 ` [PATCH 6/9] ethernet: cavium: " Philipp Stanner
2024-08-19 18:23 ` Andy Shevchenko
2024-08-20 7:40 ` Philipp Stanner
2024-08-20 10:32 ` Andy Shevchenko
2024-08-19 16:51 ` [PATCH 7/9] ethernet: stmicro: Simplify PCI devres usage Philipp Stanner
2024-08-19 18:28 ` Andy Shevchenko [this message]
2024-08-20 7:52 ` Philipp Stanner
2024-08-20 10:37 ` Andy Shevchenko
2024-08-20 10:53 ` Philipp Stanner
2024-08-19 16:51 ` [PATCH 8/9] vdap: solidrun: Replace deprecated PCI functions Philipp Stanner
2024-08-19 18:19 ` Christophe JAILLET
2024-08-19 18:34 ` Andy Shevchenko
2024-08-20 8:13 ` Philipp Stanner
2024-08-20 10:35 ` Andy Shevchenko
2024-08-20 8:09 ` Philipp Stanner
2024-08-20 10:50 ` Christophe JAILLET
2024-08-20 11:14 ` Philipp Stanner
2024-08-19 18:31 ` Andy Shevchenko
2024-08-19 18:36 ` Andy Shevchenko
2024-08-19 16:51 ` [PATCH 9/9] PCI: Remove pcim_iounmap_regions() Philipp Stanner
2024-08-19 18:35 ` Andy Shevchenko
2024-08-19 23:08 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsOO2uuGmD97Mocj@smile.fi.intel.com \
--to=andy@kernel$(echo .)org \
--cc=Jonathan.Cameron@huawei$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=alvaro.karsz@solid-run$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=bhelgaas@google$(echo .)com \
--cc=brgl@bgdev$(echo .)pl \
--cc=broonie@kernel$(echo .)org \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dlechner@baylibre$(echo .)com \
--cc=dlemoal@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=eperezma@redhat$(echo .)com \
--cc=hao.wu@intel$(echo .)com \
--cc=hare@suse$(echo .)de \
--cc=jasowang@redhat$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=kch@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-fpga@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=mdf@kernel$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pstanner@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=trix@redhat$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
--cc=yilun.xu@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox