From: Hangbin Liu <liuhangbin@gmail•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Herbert Xu <herbert@gondor•apana.org.au>,
Steffen Klassert <steffen.klassert@secunet•com>,
netdev@vger•kernel.org
Subject: Re: [Question] Does CONFIG_XFRM_OFFLOAD depends any other configs?
Date: Tue, 20 Aug 2024 09:26:49 +0800 [thread overview]
Message-ID: <ZsPw2W8nLR4azKLo@Laptop-X1> (raw)
In-Reply-To: <20240819180525.5996de13@kernel.org>
On Mon, Aug 19, 2024 at 06:05:25PM -0700, Jakub Kicinski wrote:
> On Tue, 20 Aug 2024 08:58:51 +0800 Hangbin Liu wrote:
> > > It's a hidden config option, not directly controlled by the user.
> > > You should enable INET_ESP_OFFLOAD and INET6_ESP_OFFLOAD instead
> > > (which "select" it)
> >
> > Thanks for your reply. How to know if an option is hide other than review all
> > `make menuconfig` result?
>
> If it has no description after bool or tristate -- it will be hidden
Appreciate, another tips learned.
>
> > Should we add a "depends on" for XFRM_OFFLOAD?
>
> You need it in bonding? You should use select (but not that select
Yes, I may write some xfrm offload tests for bonding.
> doesn't resolve dependencies, it only enables that single option).
I didn't get which "select" you mean here. Since INET_ESP_OFFLOAD will select
XFRM_OFFLOAD, Isn't adding
CONFIG_INET_ESP=y
CONFIG_INET_ESP_OFFLOAD=y
in tools/testing/selftests/drivers/net/bonding/config enough?
Thanks
Hangbin
next prev parent reply other threads:[~2024-08-20 1:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 23:39 [Question] Does CONFIG_XFRM_OFFLOAD depends any other configs? Hangbin Liu
2024-08-20 0:22 ` Jakub Kicinski
2024-08-20 0:58 ` Hangbin Liu
2024-08-20 1:05 ` Jakub Kicinski
2024-08-20 1:26 ` Hangbin Liu [this message]
2024-08-20 1:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsPw2W8nLR4azKLo@Laptop-X1 \
--to=liuhangbin@gmail$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox