public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
	liuhangbin@gmail•com, petrm@nvidia•com, matttbe@kernel•org,
	Shuah Khan <shuah@kernel•org>,
	netdev@vger•kernel.org, Willem de Bruijn <willemb@google•com>,
	David Wei <dw@davidwei•uk>,
	open list <linux-kernel@vger•kernel.org>,
	"open list:KERNEL SELFTEST FRAMEWORK"
	<linux-kselftest@vger•kernel.org>
Subject: Re: [PATCH net-next v5] net: netconsole: selftests: Create a new netconsole selftest
Date: Wed, 21 Aug 2024 00:58:22 -0700	[thread overview]
Message-ID: <ZsWeHpPZxUh3I1Op@gmail.com> (raw)
In-Reply-To: <20240820160636.7bfc4d5a@kernel.org>

Hello Jakub,

On Tue, Aug 20, 2024 at 04:06:36PM -0700, Jakub Kicinski wrote:
> > +# ========== #
> > +# Start here #
> > +# ========== #
> > +modprobe netdevsim 2> /dev/null || true
> > +modprobe netconsole 2 > /dev/null || true

> Main reason Im complaining, I see:
> 
> [    6.686720] netconsole: unknown parameter '2' ignored
> 
> in the kernel logs when the test runs.
> 
> Is it expected?

It is not, the reason is the space above in `modprobe netconsole 2` 

Let me update it. Thanks
--breno

  reply	other threads:[~2024-08-21  7:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19  9:03 [PATCH net-next v5] net: netconsole: selftests: Create a new netconsole selftest Breno Leitao
2024-08-20 23:06 ` Jakub Kicinski
2024-08-21  7:58   ` Breno Leitao [this message]
2024-08-21 10:48   ` Petr Machata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsWeHpPZxUh3I1Op@gmail.com \
    --to=leitao@debian$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=dw@davidwei$(echo .)uk \
    --cc=edumazet@google$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-kselftest@vger$(echo .)kernel.org \
    --cc=liuhangbin@gmail$(echo .)com \
    --cc=matttbe@kernel$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=petrm@nvidia$(echo .)com \
    --cc=shuah@kernel$(echo .)org \
    --cc=willemb@google$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox