From: Andy Shevchenko <andy@kernel•org>
To: Philipp Stanner <pstanner@redhat•com>
Cc: "Jonathan Corbet" <corbet@lwn•net>,
"Jens Axboe" <axboe@kernel•dk>, "Wu Hao" <hao.wu@intel•com>,
"Tom Rix" <trix@redhat•com>, "Moritz Fischer" <mdf@kernel•org>,
"Xu Yilun" <yilun.xu@intel•com>,
"Linus Walleij" <linus.walleij@linaro•org>,
"Bartosz Golaszewski" <brgl@bgdev•pl>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Alexandre Torgue" <alexandre.torgue@foss•st.com>,
"Jose Abreu" <joabreu@synopsys•com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail•com>,
"Bjorn Helgaas" <bhelgaas@google•com>,
"Alvaro Karsz" <alvaro.karsz@solid-run•com>,
"Michael S. Tsirkin" <mst@redhat•com>,
"Jason Wang" <jasowang@redhat•com>,
"Xuan Zhuo" <xuanzhuo@linux•alibaba.com>,
"Eugenio Pérez" <eperezma@redhat•com>,
"Richard Cochran" <richardcochran@gmail•com>,
"Mark Brown" <broonie@kernel•org>,
"David Lechner" <dlechner@baylibre•com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>,
"Damien Le Moal" <dlemoal@kernel•org>,
"Hannes Reinecke" <hare@suse•de>,
"Chaitanya Kulkarni" <kch@nvidia•com>,
linux-doc@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-block@vger•kernel.org, linux-fpga@vger•kernel.org,
linux-gpio@vger•kernel.org, netdev@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, linux-pci@vger•kernel.org,
virtualization@lists•linux.dev, stable@vger•kernel.org,
"Christophe JAILLET" <christophe.jaillet@wanadoo•fr>
Subject: Re: [PATCH v3 7/9] vdpa: solidrun: Fix UB bug with devres
Date: Thu, 22 Aug 2024 17:47:40 +0300 [thread overview]
Message-ID: <ZsdPjHAkF4i_DN3V@smile.fi.intel.com> (raw)
In-Reply-To: <20240822134744.44919-8-pstanner@redhat.com>
On Thu, Aug 22, 2024 at 03:47:39PM +0200, Philipp Stanner wrote:
> In psnet_open_pf_bar() and snet_open_vf_bar() a string later passed to
> pcim_iomap_regions() is placed on the stack. Neither
> pcim_iomap_regions() nor the functions it calls copy that string.
>
> Should the string later ever be used, this, consequently, causes
> undefined behavior since the stack frame will by then have disappeared.
>
> Fix the bug by allocating the strings on the heap through
> devm_kasprintf().
...
> - snprintf(name, sizeof(name), "psnet[%s]-bars", pci_name(pdev));
> + name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "psnet[%s]-bars", pci_name(pdev));
> + if (!name)
> + return -ENOMEM;
> +
> ret = pcim_iomap_regions(pdev, mask, name);
...
> - snprintf(name, sizeof(name), "snet[%s]-bar", pci_name(pdev));
> + name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "psnet[%s]-bars", pci_name(pdev));
> + if (!name)
> + return -ENOMEM;
+ Blank line as in the above snippet?
> /* Request and map BAR */
> ret = pcim_iomap_regions(pdev, BIT(snet->psnet->cfg.vf_bar), name);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-22 14:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 13:47 [PATCH v3 0/9] PCI: Remove pcim_iounmap_regions() Philipp Stanner
2024-08-22 13:47 ` [PATCH v3 1/9] PCI: Make pcim_iounmap_region() a public function Philipp Stanner
2024-08-22 13:47 ` [PATCH v3 2/9] fpga/dfl-pci.c: Replace deprecated PCI functions Philipp Stanner
2024-08-27 3:28 ` Xu Yilun
2024-08-22 13:47 ` [PATCH v3 3/9] block: mtip32xx: " Philipp Stanner
2024-08-22 13:47 ` [PATCH v3 4/9] gpio: " Philipp Stanner
2024-08-22 13:47 ` [PATCH v3 5/9] ethernet: cavium: " Philipp Stanner
2024-08-22 14:44 ` Andy Shevchenko
2024-08-26 14:51 ` Philipp Stanner
2024-08-26 15:41 ` Andy Shevchenko
2024-08-26 15:52 ` Philipp Stanner
2024-08-26 17:12 ` Andy Shevchenko
2024-08-22 13:47 ` [PATCH v3 6/9] ethernet: stmicro: Simplify PCI devres usage Philipp Stanner
2024-08-22 14:46 ` Andy Shevchenko
2024-08-23 9:29 ` Serge Semin
2024-08-26 6:30 ` Philipp Stanner
2024-08-22 13:47 ` [PATCH v3 7/9] vdpa: solidrun: Fix UB bug with devres Philipp Stanner
2024-08-22 14:34 ` Christophe JAILLET
2024-08-26 6:55 ` Philipp Stanner
2024-08-22 14:47 ` Andy Shevchenko [this message]
2024-08-22 13:47 ` [PATCH v3 8/9] vdap: solidrun: Replace deprecated PCI functions Philipp Stanner
2024-08-22 14:49 ` Andy Shevchenko
2024-08-22 13:47 ` [PATCH v3 9/9] PCI: Remove pcim_iounmap_regions() Philipp Stanner
2024-08-22 14:50 ` [PATCH v3 0/9] " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsdPjHAkF4i_DN3V@smile.fi.intel.com \
--to=andy@kernel$(echo .)org \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=alvaro.karsz@solid-run$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=bhelgaas@google$(echo .)com \
--cc=brgl@bgdev$(echo .)pl \
--cc=broonie@kernel$(echo .)org \
--cc=christophe.jaillet@wanadoo$(echo .)fr \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dlechner@baylibre$(echo .)com \
--cc=dlemoal@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=eperezma@redhat$(echo .)com \
--cc=hao.wu@intel$(echo .)com \
--cc=hare@suse$(echo .)de \
--cc=jasowang@redhat$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=kch@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-fpga@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=mdf@kernel$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pstanner@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=stable@vger$(echo .)kernel.org \
--cc=trix@redhat$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
--cc=yilun.xu@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox