Subject: Re: [PATCH net 2/3] i2c: designware: add device private data passing to lock functions

From: Andy Shevchenko <[email-masked]>
Date: Fri, 23 Aug 2024 17:06:56 +0300

On Fri, Aug 23, 2024 at 11:02:41AM +0800, Jiawen Wu wrote:
> In order to add the hardware lock for Wangxun devices with minimal
> modification, pass struct dw_i2c_dev to the acquire and release lock
> functions.

...

> +static int iosf_mbi_block_punit_i2c_access_dev(struct dw_i2c_dev *dev)

> +static void iosf_mbi_unblock_punit_i2c_access_dev(struct dw_i2c_dev *dev)

Rather name them in accordance with the namespace of this module.

-- 
With Best Regards,
Andy Shevchenko