Subject: Re: [PATCH net-next v3 4/8] net: ethernet: fs_enet: only protect the .restart() call in .adjust_link

From: "Russell King (Oracle)" <[email-masked]>
Date: Mon, 16 Sep 2024 18:49:27 +0100

On Wed, Sep 04, 2024 at 07:18:17PM +0200, Maxime Chevallier wrote:
>  /* generic link-change handler - should be sufficient for most cases */
> -static void generic_adjust_link(struct  net_device *dev)
> +static void fs_adjust_link(struct  net_device *dev)

As you're changing the function name, I think getting rid of the double
space in 'struct  net_device' would be worthwhile.

Thanks.

-- 
*** please note that I probably will only be occasionally responsive
*** for an unknown period of time due to recent eye surgery making
*** reading quite difficult.

RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!