From: Andy Shevchenko <andriy.shevchenko@intel•com>
To: Przemek Kitszel <przemyslaw.kitszel@intel•com>
Cc: linux-kernel@vger•kernel.org,
amadeuszx.slawinski@linux•intel.com,
Tony Nguyen <anthony.l.nguyen@intel•com>,
nex.sw.ncis.osdt.itp.upstreaming@intel•com,
netdev@vger•kernel.org, Markus Elfring <Markus.Elfring@web•de>,
Kees Cook <kees@kernel•org>,
Dmitry Torokhov <dmitry.torokhov@gmail•com>,
Dan Carpenter <dan.carpenter@linaro•org>,
Peter Zijlstra <peterz@infradead•org>
Subject: Re: [PATCH v1] cleanup: adjust scoped_guard() to avoid potential warning
Date: Thu, 3 Oct 2024 15:46:24 +0300 [thread overview]
Message-ID: <Zv6SIHeN_nOWSH41@smile.fi.intel.com> (raw)
In-Reply-To: <Zv6RZS3bjfNcwh-B@smile.fi.intel.com>
On Thu, Oct 03, 2024 at 03:43:17PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 03, 2024 at 01:39:06PM +0200, Przemek Kitszel wrote:
...
> > +#define __scoped_guard_labeled(_label, _name, args...) \
> > + for (CLASS(_name, scope)(args); \
> > + __guard_ptr(_name)(&scope) || !__is_cond_ptr(_name); \
> > + ({ goto _label; })) \
> > + if (0) \
> > + _label: \
> > + break; \
> > + else
>
> I believe the following will folow more the style we use in the kernel:
>
> #define __scoped_guard_labeled(_label, _name, args...) \
> for (CLASS(_name, scope)(args); \
> __guard_ptr(_name)(&scope) || !__is_cond_ptr(_name); \
> ({ goto _label; })) \
> if (0) { \
> _label: \
> break; \
> } else
>
> ...
>
> > - *done = NULL; !done; done = (void *)1) \
> > + *done = NULL; !done; done = (void *)1 + \
>
> You have TABs/spaces mix in this line now.
And FWIW:
1) still NAKed;
2) interestingly you haven't mentioned that meanwhile I also helped you to
improve this version of the patch. Is it because I NAKed it?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-03 12:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 11:39 [PATCH v1] cleanup: adjust scoped_guard() to avoid potential warning Przemek Kitszel
2024-10-03 12:34 ` Markus Elfring
2024-10-03 12:44 ` Andy Shevchenko
2024-10-03 16:00 ` Markus Elfring
2024-10-07 10:13 ` Przemek Kitszel
2024-10-07 10:46 ` Markus Elfring
2024-10-03 12:43 ` [PATCH v1] " Andy Shevchenko
2024-10-03 12:46 ` Andy Shevchenko [this message]
2024-10-03 13:38 ` Przemek Kitszel
2024-10-03 17:47 ` Andy Shevchenko
2024-10-03 14:12 ` Peter Zijlstra
2024-10-03 17:51 ` Andy Shevchenko
2024-10-04 9:33 ` Peter Zijlstra
2024-10-04 13:52 ` Andy Shevchenko
2024-10-03 13:00 ` Dmitry Torokhov
2024-10-03 13:42 ` Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv6SIHeN_nOWSH41@smile.fi.intel.com \
--to=andriy.shevchenko@intel$(echo .)com \
--cc=Markus.Elfring@web$(echo .)de \
--cc=amadeuszx.slawinski@linux$(echo .)intel.com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=dan.carpenter@linaro$(echo .)org \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=kees@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=przemyslaw.kitszel@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox