* [PATCH net] net: pcs: xpcs: fix the wrong register that was written back
@ 2024-09-24 2:28 Jiawen Wu
2024-09-24 8:28 ` Russell King (Oracle)
2024-10-01 9:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jiawen Wu @ 2024-09-24 2:28 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev
Cc: mengyuanlou, Jiawen Wu, stable
The value is read from the register TXGBE_RX_GEN_CTL3, and it should be
written back to TXGBE_RX_GEN_CTL3 when it changes some fields.
Cc: stable@vger•kernel.org
Fixes: f629acc6f210 ("net: pcs: xpcs: support to switch mode for Wangxun NICs")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic•com>
---
drivers/net/pcs/pcs-xpcs-wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/pcs/pcs-xpcs-wx.c b/drivers/net/pcs/pcs-xpcs-wx.c
index 19c75886f070..5f5cd3596cb8 100644
--- a/drivers/net/pcs/pcs-xpcs-wx.c
+++ b/drivers/net/pcs/pcs-xpcs-wx.c
@@ -109,7 +109,7 @@ static void txgbe_pma_config_1g(struct dw_xpcs *xpcs)
txgbe_write_pma(xpcs, TXGBE_DFE_TAP_CTL0, 0);
val = txgbe_read_pma(xpcs, TXGBE_RX_GEN_CTL3);
val = u16_replace_bits(val, 0x4, TXGBE_RX_GEN_CTL3_LOS_TRSHLD0);
- txgbe_write_pma(xpcs, TXGBE_RX_EQ_ATTN_CTL, val);
+ txgbe_write_pma(xpcs, TXGBE_RX_GEN_CTL3, val);
txgbe_write_pma(xpcs, TXGBE_MPLLA_CTL0, 0x20);
txgbe_write_pma(xpcs, TXGBE_MPLLA_CTL3, 0x46);
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: pcs: xpcs: fix the wrong register that was written back
2024-09-24 2:28 [PATCH net] net: pcs: xpcs: fix the wrong register that was written back Jiawen Wu
@ 2024-09-24 8:28 ` Russell King (Oracle)
2024-10-01 9:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Russell King (Oracle) @ 2024-09-24 8:28 UTC (permalink / raw)
To: Jiawen Wu
Cc: andrew, hkallweit1, davem, edumazet, kuba, pabeni, netdev,
mengyuanlou, stable
On Tue, Sep 24, 2024 at 10:28:57AM +0800, Jiawen Wu wrote:
> The value is read from the register TXGBE_RX_GEN_CTL3, and it should be
> written back to TXGBE_RX_GEN_CTL3 when it changes some fields.
>
> Cc: stable@vger•kernel.org
Reported-by: Russell King (Oracle) <rmk+kernel@armlinux•org.uk>
> Fixes: f629acc6f210 ("net: pcs: xpcs: support to switch mode for Wangxun NICs")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic•com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux•org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: pcs: xpcs: fix the wrong register that was written back
2024-09-24 2:28 [PATCH net] net: pcs: xpcs: fix the wrong register that was written back Jiawen Wu
2024-09-24 8:28 ` Russell King (Oracle)
@ 2024-10-01 9:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-01 9:10 UTC (permalink / raw)
To: Jiawen Wu
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev,
mengyuanlou, stable
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat•com>:
On Tue, 24 Sep 2024 10:28:57 +0800 you wrote:
> The value is read from the register TXGBE_RX_GEN_CTL3, and it should be
> written back to TXGBE_RX_GEN_CTL3 when it changes some fields.
>
> Cc: stable@vger•kernel.org
> Fixes: f629acc6f210 ("net: pcs: xpcs: support to switch mode for Wangxun NICs")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic•com>
>
> [...]
Here is the summary with links:
- [net] net: pcs: xpcs: fix the wrong register that was written back
https://git.kernel.org/netdev/net/c/93ef6ee5c20e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-01 9:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24 2:28 [PATCH net] net: pcs: xpcs: fix the wrong register that was written back Jiawen Wu
2024-09-24 8:28 ` Russell King (Oracle)
2024-10-01 9:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox