From: Hangbin Liu <liuhangbin@gmail•com>
To: Paolo Abeni <pabeni@redhat•com>,
Steffen Klassert <steffen.klassert@secunet•com>,
Sabrina Dubroca <sd@queasysnail•net>
Cc: netdev@vger•kernel.org, Jay Vosburgh <jv@jvosburgh•net>,
Andy Gospodarek <andy@greyhouse•net>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Jarod Wilson <jarod@redhat•com>,
Nikolay Aleksandrov <razor@blackwall•org>,
Simon Horman <horms@kernel•org>,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH net] Bonding: update bond device XFRM features based on current active slave
Date: Wed, 25 Sep 2024 13:21:40 +0000 [thread overview]
Message-ID: <ZvQOZALIQWOcPRAn@fedora> (raw)
In-Reply-To: <ZvOx95zrrKonjTPn@fedora>
On Wed, Sep 25, 2024 at 06:47:27AM +0000, Hangbin Liu wrote:
> On Tue, Sep 24, 2024 at 03:17:25PM +0200, Paolo Abeni wrote:
> >
> >
> > On 9/18/24 10:35, Hangbin Liu wrote:
> > > XFRM offload is supported in active-backup mode. However, if the current
> > > active slave does not support it, we should disable it on bond device.
> > > Otherwise, ESP traffic may fail due to the downlink not supporting the
> > > feature.
> >
> > Why would the excessive features exposed by the bond device will be a
> > problem? later dev_queue_xmit() on the lower device should take care of
> > needed xfrm offload in validate_xmit_xfrm(), no?
>
> I'm not very sure. In validate_xmit_xfrm() it looks the lower dev won't
> check again if the upper dev has validated.
>
> /* This skb was already validated on the upper/virtual dev */
> if ((x->xso.dev != dev) && (x->xso.real_dev == dev))
> return skb;
>
> Hi Sabrina, Steffen, if the upper dev validate failed, what would happen?
> Just drop the skb or go via software path?
Hmm, I saw a similar commit 28581b9c2c94 ("bond: Disable TLS features
indication"). I will check the history and see if we can do like this.
Thanks
Hangbin
prev parent reply other threads:[~2024-09-25 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 8:35 [PATCH net] Bonding: update bond device XFRM features based on current active slave Hangbin Liu
2024-09-18 9:40 ` Nikolay Aleksandrov
2024-09-24 13:17 ` Paolo Abeni
2024-09-25 6:47 ` Hangbin Liu
2024-09-25 13:21 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvQOZALIQWOcPRAn@fedora \
--to=liuhangbin@gmail$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jarod@redhat$(echo .)com \
--cc=jv@jvosburgh$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=sd@queasysnail$(echo .)net \
--cc=steffen.klassert@secunet$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox