Subject: Re: [PATCH] Fix issue related with assigning two diffrent vids to the same interface.

From: Hangbin Liu <[email-masked]>
Date: Thu, 26 Sep 2024 02:12:55 +0000

Hi Kacper,

When you post a second patch, you need to add PATCHv2 in the subject.

On Wed, Sep 25, 2024 at 02:05:39PM +0900, Kacper Ludwinski wrote:
> Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test")
> Signed-off-by: Kacper Ludwinski <[email-masked]>
> ---
>  tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/forwarding/no_forwarding.sh b/tools/testing/selftests/net/forwarding/no_forwarding.sh
> index 9e677aa64a06..694ece9ba3a7 100755
> --- a/tools/testing/selftests/net/forwarding/no_forwarding.sh
> +++ b/tools/testing/selftests/net/forwarding/no_forwarding.sh
> @@ -202,7 +202,7 @@ one_bridge_two_pvids()
>  	ip link set $swp2 master br0
>  
>  	bridge vlan add dev $swp1 vid 1 pvid untagged
> -	bridge vlan add dev $swp1 vid 2 pvid untagged
> +	bridge vlan add dev $swp2 vid 2 pvid untagged
>  
>  	run_test "Switch ports in VLAN-aware bridge with different PVIDs"
>  
The patch looks good to me.

Reviewed-by: Hangbin Liu <[email-masked]>