Subject: Re: [PATCH v2 2/2] netfilter: nf_tables: Fix percpu address space issues in nf_tables_api.c

From: Pablo Neira Ayuso <[email-masked]>
Date: Fri, 4 Oct 2024 13:13:38 +0200

On Thu, Aug 29, 2024 at 05:29:32PM +0200, Uros Bizjak wrote:
> Compiling nf_tables_api.c results in several sparse warnings:
> 
> nf_tables_api.c:2077:31: warning: incorrect type in return expression (different address spaces)
> nf_tables_api.c:2080:31: warning: incorrect type in return expression (different address spaces)
> nf_tables_api.c:2084:31: warning: incorrect type in return expression (different address spaces)
> 
> nf_tables_api.c:2740:23: warning: incorrect type in assignment (different address spaces)
> nf_tables_api.c:2752:38: warning: incorrect type in assignment (different address spaces)
> nf_tables_api.c:2798:21: warning: incorrect type in argument 1 (different address spaces)
> 
> Use {ERR_PTR,IS_ERR,PTR_ERR}_PCPU() macros when crossing between generic
> and percpu address spaces and add __percpu annotation to *stats pointer
> to fix these warnings.
> 
> Found by GCC's named address space checks.
> 
> There were no changes in the resulting object files.

ERR_PTR,IS_ERR,PTR_ERR}_PCPU() dependency is now in nf-next.git.

Applied, thanks