From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Abhishek Chauhan <quic_abchauha@quicinc•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
Andrew Halaney <ahalaney@redhat•com>,
Andrew Lunn <andrew@lunn•ch>,
Heiner Kallweit <hkallweit1@gmail•com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro•org>,
"linux-tegra@vger•kernel.org" <linux-tegra@vger•kernel.org>,
Brad Griffis <bgriffis@nvidia•com>,
Vladimir Oltean <vladimir.oltean@nxp•com>,
Jon Hunter <jonathanh@nvidia•com>,
Maxime Chevallier <maxime.chevallier@bootlin•com>,
Przemek Kitszel <przemyslaw.kitszel@intel•com>,
kernel@quicinc•com
Subject: Re: [PATCH net v5 2/2] net: phy: aquantia: remove usage of phy_set_max_speed
Date: Tue, 1 Oct 2024 13:00:55 +0100 [thread overview]
Message-ID: <Zvvkd1Xi4/rmWQRf@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240930223341.3807222-3-quic_abchauha@quicinc.com>
Hi,
On Mon, Sep 30, 2024 at 03:33:41PM -0700, Abhishek Chauhan wrote:
> +static int aqr111_get_features(struct phy_device *phydev)
> +{
> + /* PHY FIXUP */
> + /* Phy supports Speeds up to 5G with Autoneg though the phy PMA says otherwise */
> + aqr115c_get_features(phydev);
> + linkmode_set_bit(ETHTOOL_LINK_MODE_5000baseT_Full_BIT, phydev->supported);
More or less same as the previous. The comment could do with shortening.
I think for this linkmode_set_bit(), it's not worth using a local
"supported" variable, so just put phydev->... on the following line to
avoid the long line.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-10-01 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 22:33 [PATCH net v5 0/2] Fix AQR PMA capabilities Abhishek Chauhan
2024-09-30 22:33 ` [PATCH net v5 1/2] net: phy: aquantia: AQR115c fix up " Abhishek Chauhan
2024-10-01 11:59 ` Russell King (Oracle)
2024-10-01 18:06 ` Abhishek Chauhan (ABC)
2024-09-30 22:33 ` [PATCH net v5 2/2] net: phy: aquantia: remove usage of phy_set_max_speed Abhishek Chauhan
2024-10-01 12:00 ` Russell King (Oracle) [this message]
2024-10-01 18:06 ` Abhishek Chauhan (ABC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zvvkd1Xi4/rmWQRf@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=ahalaney@redhat$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=bartosz.golaszewski@linaro$(echo .)org \
--cc=bgriffis@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kernel@quicinc$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=quic_abchauha@quicinc$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox