From: Jiri Pirko <jiri@resnulli•us>
To: Vadim Fedorenko <vadim.fedorenko@linux•dev>
Cc: Jakub Kicinski <kuba@kernel•org>,
netdev@vger•kernel.org, davem@davemloft•net, edumazet@google•com,
pabeni@redhat•com, donald.hunter@gmail•com,
arkadiusz.kubalewski@intel•com, saeedm@nvidia•com,
leon@kernel•org, tariqt@nvidia•com
Subject: Re: [PATCH net-next v3 1/2] dpll: add clock quality level attribute and op
Date: Tue, 15 Oct 2024 16:56:03 +0200 [thread overview]
Message-ID: <Zw6Cg1giDaFwVCio@nanopsycho.orion> (raw)
In-Reply-To: <2ec44c11-8387-4c38-97f4-a1fbcb5e1a4e@linux.dev>
Tue, Oct 15, 2024 at 04:50:41PM CEST, vadim.fedorenko@linux•dev wrote:
>On 15/10/2024 15:26, Jakub Kicinski wrote:
>> On Mon, 14 Oct 2024 10:11:32 +0200 Jiri Pirko wrote:
>> > + type: enum
>> > + name: clock-quality-level
>> > + doc: |
>> > + level of quality of a clock device. This mainly applies when
>> > + the dpll lock-status is not DPLL_LOCK_STATUS_LOCKED.
>> > + The current list is defined according to the table 11-7 contained
>> > + in ITU-T G.8264/Y.1364 document. One may extend this list freely
>> > + by other ITU-T defined clock qualities, or different ones defined
>> > + by another standardization body (for those, please use
>> > + different prefix).
>>
>> uAPI extensibility aside - doesn't this belong to clock info?
>> I'm slightly worried we're stuffing this attr into DPLL because
>> we have netlink for DPLL but no good way to extend clock info.
>
>There is a work going on by Maciek Machnikowski about extending clock
>info. But the progress is kinda slow..
Do you have some info about this? A list of attrs at least would help.
>
>> > + entries:
>> > + -
>> > + name: itu-opt1-prc
>> > + value: 1
>> > + -
>> > + name: itu-opt1-ssu-a
>> > + -
>> > + name: itu-opt1-ssu-b
>> > + -
>> > + name: itu-opt1-eec1
>> > + -
>> > + name: itu-opt1-prtc
>> > + -
>> > + name: itu-opt1-eprtc
>> > + -
>> > + name: itu-opt1-eeec
>> > + -
>> > + name: itu-opt1-eprc
>> > + render-max: true
>>
>> Why render max? Just to align with other unnecessary max defines in
>> the file?
>
next prev parent reply other threads:[~2024-10-15 14:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 8:11 [PATCH net-next v3 0/2] dpll: expose clock quality level Jiri Pirko
2024-10-14 8:11 ` [PATCH net-next v3 1/2] dpll: add clock quality level attribute and op Jiri Pirko
2024-10-14 8:54 ` Kubalewski, Arkadiusz
2024-10-15 14:26 ` Jakub Kicinski
2024-10-15 14:38 ` Jiri Pirko
2024-10-15 15:01 ` Jakub Kicinski
2024-10-16 8:19 ` Jiri Pirko
2024-10-18 7:07 ` Jiri Pirko
2024-10-28 17:14 ` Jakub Kicinski
2024-10-29 12:52 ` Jiri Pirko
2024-10-29 13:51 ` Jakub Kicinski
2024-10-29 14:41 ` Jiri Pirko
2024-10-16 8:21 ` Jiri Pirko
2024-10-15 14:50 ` Vadim Fedorenko
2024-10-15 14:56 ` Jiri Pirko [this message]
2024-10-15 15:01 ` Vadim Fedorenko
2024-10-16 8:17 ` Jiri Pirko
2024-10-14 8:11 ` [PATCH net-next v3 2/2] net/mlx5: DPLL, Add clock quality level op implementation Jiri Pirko
2024-10-14 8:57 ` Kubalewski, Arkadiusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw6Cg1giDaFwVCio@nanopsycho.orion \
--to=jiri@resnulli$(echo .)us \
--cc=arkadiusz.kubalewski@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox