From: Florian Westphal <fw@strlen•de>
To: Tyrone Wu <wudevelops@gmail•com>
Cc: bpf@vger•kernel.org, pablo@netfilter•org, kadlec@netfilter•org,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, andrii@kernel•org, eddyz87@gmail•com,
mykolal@fb•com, ast@kernel•org, daniel@iogearbox•net,
martin.lau@linux•dev, song@kernel•org, yonghong.song@linux•dev,
john.fastabend@gmail•com, kpsingh@kernel•org, sdf@fomichev•me,
haoluo@google•com, jolsa@kernel•org, shuah@kernel•org,
riel@surriel•com, shakeel.butt@linux•dev,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-kselftest@vger•kernel.org, kernel-patches-bot@fb•com
Subject: Re: [PATCH bpf v1 1/2] bpf: fix link info netfilter flags to populate defrag flag
Date: Tue, 15 Oct 2024 17:25:22 +0200 [thread overview]
Message-ID: <Zw6JYuga41DyoVjt@strlen.de> (raw)
In-Reply-To: <20241011193252.178997-1-wudevelops@gmail.com>
Tyrone Wu <wudevelops@gmail•com> wrote:
> This patch correctly populates the `bpf_link_info.netfilter.flags` field
> when user passes the `BPF_F_NETFILTER_IP_DEFRAG` flag.
Indeed, thanks for fixing this.
Patch and testcase look good, but one nit:
> Fixes: 84601d6ee68a ("bpf: add bpf_link support for BPF_NETFILTER programs")
BPF_F_NETFILTER_IP_DEFRAG flag was added in
91721c2d02d3 ("netfilter: bpf: Support BPF_F_NETFILTER_IP_DEFRAG in netfilter link"), that was a bit later than the initial support.
Other than that,
Acked-by: Florian Westphal <fw@strlen•de>
next prev parent reply other threads:[~2024-10-15 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 19:32 [PATCH bpf v1 1/2] bpf: fix link info netfilter flags to populate defrag flag Tyrone Wu
2024-10-11 19:32 ` [PATCH bpf v1 2/2] selftests/bpf: add asserts for netfilter link info Tyrone Wu
2024-10-15 15:25 ` Florian Westphal [this message]
2024-10-16 15:13 ` [PATCH bpf v1 1/2] bpf: fix link info netfilter flags to populate defrag flag Daniel Borkmann
2024-10-16 15:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw6JYuga41DyoVjt@strlen.de \
--to=fw@strlen$(echo .)de \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=coreteam@netfilter$(echo .)org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=eddyz87@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=haoluo@google$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kadlec@netfilter$(echo .)org \
--cc=kernel-patches-bot@fb$(echo .)com \
--cc=kpsingh@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=martin.lau@linux$(echo .)dev \
--cc=mykolal@fb$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=riel@surriel$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=shakeel.butt@linux$(echo .)dev \
--cc=shuah@kernel$(echo .)org \
--cc=song@kernel$(echo .)org \
--cc=wudevelops@gmail$(echo .)com \
--cc=yonghong.song@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox