From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Philipp Stanner <pstanner@redhat•com>
Cc: "Damien Le Moal" <dlemoal@kernel•org>,
"Niklas Cassel" <cassel@kernel•org>,
"Sergey Shtylyov" <s.shtylyov@omp•ru>,
"Basavaraj Natikar" <basavaraj.natikar@amd•com>,
"Jiri Kosina" <jikos@kernel•org>,
"Benjamin Tissoires" <bentiss@kernel•org>,
"Arnd Bergmann" <arnd@arndb•de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Alex Dubov" <oakad@yahoo•com>,
"Sudarsana Kalluru" <skalluru@marvell•com>,
"Manish Chopra" <manishc@marvell•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Rasesh Mody" <rmody@marvell•com>,
GR-Linux-NIC-Dev@marvell•com,
"Igor Mitsyanko" <imitsyanko@quantenna•com>,
"Sergey Matyukevich" <geomatsi@gmail•com>,
"Kalle Valo" <kvalo@kernel•org>,
"Sanjay R Mehta" <sanju.mehta@amd•com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd•com>,
"Jon Mason" <jdmason@kudzu•us>,
"Dave Jiang" <dave.jiang@intel•com>,
"Allen Hubbe" <allenbh@gmail•com>,
"Bjorn Helgaas" <bhelgaas@google•com>,
"Alex Williamson" <alex.williamson@redhat•com>,
"Juergen Gross" <jgross@suse•com>,
"Stefano Stabellini" <sstabellini@kernel•org>,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam•com>,
"Jaroslav Kysela" <perex@perex•cz>,
"Takashi Iwai" <tiwai@suse•com>,
"Mario Limonciello" <mario.limonciello@amd•com>,
"Chen Ni" <nichen@iscas•ac.cn>, "Ricky Wu" <ricky_wu@realtek•com>,
"Al Viro" <viro@zeniv•linux.org.uk>,
"Breno Leitao" <leitao@debian•org>,
"Kevin Tian" <kevin.tian@intel•com>,
"Thomas Gleixner" <tglx@linutronix•de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux•intel.com>,
"Mostafa Saleh" <smostafa@google•com>,
"Hannes Reinecke" <hare@suse•de>,
"John Garry" <john.g.garry@oracle•com>,
"Soumya Negi" <soumya.negi97@gmail•com>,
"Jason Gunthorpe" <jgg@ziepe•ca>, "Yi Liu" <yi.l.liu@intel•com>,
"Dr. David Alan Gilbert" <linux@treblig•org>,
"Christian Brauner" <brauner@kernel•org>,
"Ankit Agrawal" <ankita@nvidia•com>,
"Reinette Chatre" <reinette.chatre@intel•com>,
"Eric Auger" <eric.auger@redhat•com>,
"Ye Bin" <yebin10@huawei•com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab•com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux•dev>,
"Maarten Lankhorst" <maarten.lankhorst@linux•intel.com>,
"Kai Vehmanen" <kai.vehmanen@linux•intel.com>,
"Peter Ujfalusi" <peter.ujfalusi@linux•intel.com>,
"Rui Salvaterra" <rsalvaterra@gmail•com>,
"Marc Zyngier" <maz@kernel•org>,
linux-ide@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-input@vger•kernel.org, netdev@vger•kernel.org,
linux-wireless@vger•kernel.org, ntb@lists•linux.dev,
linux-pci@vger•kernel.org, linux-staging@lists•linux.dev,
kvm@vger•kernel.org, xen-devel@lists•xenproject.org,
linux-sound@vger•kernel.org
Subject: Re: [RFC PATCH 02/13] ALSA: hda: hda_intel: Use always-managed version of pcim_intx()
Date: Thu, 10 Oct 2024 17:46:57 +0300 [thread overview]
Message-ID: <Zwfo4dr4bfqQGGyl@smile.fi.intel.com> (raw)
In-Reply-To: <20241009083519.10088-3-pstanner@redhat.com>
On Wed, Oct 09, 2024 at 10:35:08AM +0200, Philipp Stanner wrote:
> pci_intx() is a hybrid function which can sometimes be managed through
> devres. To remove this hybrid nature from pci_intx(), it is necessary to
> port users to either an always-managed or a never-managed version.
>
> hda_intel enables its PCI-Device with pcim_enable_device(). Thus, it needs
> the always-managed version.
>
> Replace pci_intx() with pcim_intx().
...
> bus->irq = chip->pci->irq;
> chip->card->sync_irq = bus->irq;
> - pci_intx(chip->pci, !chip->msi);
> + pcim_intx(chip->pci, !chip->msi);
> return 0;
I believe each driver needs an individual approach. Looking at the above
I would first to understand why this one is being used and why we can't
switch to pci{m}_alloc_irq_vectors(). (Yeah, managed pci_alloc_irq_vectors()
is probably still missing, I don't remember if you introduced it or not.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-10 14:47 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 8:35 [RFC PATCH 00/13] Remove implicit devres from pci_intx() Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 01/13] PCI: Prepare removing " Philipp Stanner
2024-10-09 9:10 ` Damien Le Moal
2024-10-10 14:40 ` Andy Shevchenko
2024-10-11 12:16 ` Philipp Stanner
2024-10-11 13:50 ` Andy Shevchenko
2024-10-14 9:12 ` Philipp Stanner
2024-10-10 17:43 ` Alex Williamson
2024-10-11 12:03 ` Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 02/13] ALSA: hda: hda_intel: Use always-managed version of pcim_intx() Philipp Stanner
2024-10-10 14:46 ` Andy Shevchenko [this message]
2024-10-11 12:27 ` Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 03/13] drivers/xen: Use never-managed version of pci_intx() Philipp Stanner
2024-10-09 8:51 ` Juergen Gross
2024-10-09 10:50 ` Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 04/13] net/ethernet: " Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 05/13] net/ntb: " Philipp Stanner
2024-10-10 4:37 ` Shyam Sundar S K
2024-10-10 4:42 ` Shyam Sundar S K
2024-10-09 8:35 ` [RFC PATCH 06/13] misc: " Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 07/13] vfio/pci: " Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 08/13] PCI: MSI: " Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 09/13] ata: Use always-managed " Philipp Stanner
2024-10-09 8:51 ` Damien Le Moal
2024-10-09 10:55 ` Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 10/13] staging: rts5280: " Philipp Stanner
2024-10-09 9:38 ` Greg Kroah-Hartman
2024-10-09 19:41 ` Philipp Hortmann
2024-10-10 8:03 ` Philipp Stanner
2024-10-10 9:03 ` Greg Kroah-Hartman
2024-10-10 9:12 ` Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 11/13] wifi: qtnfmac: use always-managed version of pcim_intx() Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 12/13] HID: amd_sfh: Use " Philipp Stanner
2024-10-10 7:20 ` Basavaraj Natikar
2024-10-09 8:35 ` [RFC PATCH 13/13] Remove devres from pci_intx() Philipp Stanner
2024-10-10 8:50 ` Dan Carpenter
2024-10-10 9:11 ` Philipp Stanner
2024-10-10 17:43 ` Alex Williamson
2024-10-10 18:34 ` Dan Carpenter
2024-10-11 12:07 ` Philipp Stanner
2024-10-09 18:32 ` [RFC PATCH 00/13] Remove implicit " Heiner Kallweit
2024-10-10 8:09 ` Philipp Stanner
2024-10-10 14:50 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zwfo4dr4bfqQGGyl@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=GR-Linux-NIC-Dev@marvell$(echo .)com \
--cc=Shyam-sundar.S-k@amd$(echo .)com \
--cc=alex.williamson@redhat$(echo .)com \
--cc=allenbh@gmail$(echo .)com \
--cc=ankita@nvidia$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=basavaraj.natikar@amd$(echo .)com \
--cc=bentiss@kernel$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=brauner@kernel$(echo .)org \
--cc=cassel@kernel$(echo .)org \
--cc=dave.jiang@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dlemoal@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=eric.auger@redhat$(echo .)com \
--cc=geomatsi@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hare@suse$(echo .)de \
--cc=ilpo.jarvinen@linux$(echo .)intel.com \
--cc=imitsyanko@quantenna$(echo .)com \
--cc=jdmason@kudzu$(echo .)us \
--cc=jgg@ziepe$(echo .)ca \
--cc=jgross@suse$(echo .)com \
--cc=jikos@kernel$(echo .)org \
--cc=john.g.garry@oracle$(echo .)com \
--cc=kai.vehmanen@linux$(echo .)intel.com \
--cc=kevin.tian@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=leitao@debian$(echo .)org \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-sound@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux@treblig$(echo .)org \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=manishc@marvell$(echo .)com \
--cc=mario.limonciello@amd$(echo .)com \
--cc=marmarek@invisiblethingslab$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nichen@iscas$(echo .)ac.cn \
--cc=ntb@lists$(echo .)linux.dev \
--cc=oakad@yahoo$(echo .)com \
--cc=oleksandr_tyshchenko@epam$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=peter.ujfalusi@linux$(echo .)intel.com \
--cc=pierre-louis.bossart@linux$(echo .)dev \
--cc=pstanner@redhat$(echo .)com \
--cc=reinette.chatre@intel$(echo .)com \
--cc=ricky_wu@realtek$(echo .)com \
--cc=rmody@marvell$(echo .)com \
--cc=rsalvaterra@gmail$(echo .)com \
--cc=s.shtylyov@omp$(echo .)ru \
--cc=sanju.mehta@amd$(echo .)com \
--cc=skalluru@marvell$(echo .)com \
--cc=smostafa@google$(echo .)com \
--cc=soumya.negi97@gmail$(echo .)com \
--cc=sstabellini@kernel$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tiwai@suse$(echo .)com \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=xen-devel@lists$(echo .)xenproject.org \
--cc=yebin10@huawei$(echo .)com \
--cc=yi.l.liu@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox