Subject: Re: [PATCH net-next 3/3] net: phylink: simplify how SFP PHYs are attached

From: "Russell King (Oracle)" <[email-masked]>
Date: Tue, 22 Oct 2024 12:58:05 +0100

On Tue, Oct 22, 2024 at 12:54:17PM +0100, Russell King (Oracle) wrote:
> There are a few issues with how SFP PHYs are attached:
> 
> a) The phylink_sfp_connect_phy() and phylink_sfp_config_phy() code
>    validates the configuration three times:
> 
> 1. To discover the support/advertising masks that the PHY/PCS/MAC
>    can support in order to select an interface.
> 2. To validate the selected interface.
> 3. When the PHY is brought up after being attached, another validation
>    is done.
> 
>    This is needlessly complex.
> 
> b) The configuration is set prior to the PHY being attached, which
>    means we don't have the PHY available in phylink_major_config()
>    for phylink_pcs_neg_mode() to make decisions upon.
> 
> We have already added an extra step to validate the selected interface,
> so we can now move the attachment and bringup of the PHY earlier,
> inside phylink_sfp_config_phy(). This results in the validation at
> step 2 above becoming entirely unnecessary, so remove that too.
> 
> Signed-off-by: Russell King (Oracle) <[email-masked]>

There's a build warning in this patch, which I'll address - but please
let me have any comments in the mean time.

>  static int phylink_sfp_connect_phy(void *upstream, struct phy_device *phy)
>  {
>  	struct phylink *pl = upstream;
> -	phy_interface_t interface;
>  	u8 mode;
>  	int ret;

"ret" needs to be removed.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!