Subject: Re: [PATCH net-next v2 2/2] netlink: specs: Add a spec for FIB rule management

From: Ido Schimmel <[email-masked]>
Date: Tue, 5 Nov 2024 16:35:29 +0200

On Tue, Nov 05, 2024 at 12:28:31PM +0000, Donald Hunter wrote:
> Add a YNL spec for FIB rules:
> 
> ./tools/net/ynl/cli.py \
>     --spec Documentation/netlink/specs/rt_rule.yaml \
>     --dump getrule --json '{"family": 2}'
> 
> [{'action': 'to-tbl',
>   'dst-len': 0,
>   'family': 2,
>   'flags': 0,
>   'protocol': 2,
>   'src-len': 0,
>   'suppress-prefixlen': '0xffffffff',
>   'table': 255,
>   'tos': 0},
>   ... ]
> 
> Acked-by: Stanislav Fomichev <[email-masked]>
> Signed-off-by: Donald Hunter <[email-masked]>

Reviewed-by: Ido Schimmel <[email-masked]>

One question below (didn't notice it before)

[...]

> +    -
> +      name: getrule
> +      doc: Dump all FIB rules
> +      attribute-set: fib-rule-attrs
> +      dump:
> +        request:
> +          value: 34
> +          attributes:
> +            - nsid

What is the significance of 'nsid' here?

> +        reply:
> +          value: 32
> +          attributes: *fib-rule-all