From: Joe Damato <jdamato@fastly•com>
To: Stanislav Fomichev <stfomichev@gmail•com>
Cc: netdev@vger•kernel.org, corbet@lwn•net, hdanton@sina•com,
bagasdotme@gmail•com, pabeni@redhat•com, namangulati@google•com,
edumazet@google•com, amritha.nambiar@intel•com,
sridhar.samudrala@intel•com, sdf@fomichev•me, peter@typeblog•net,
m2shafiei@uwaterloo•ca, bjorn@rivosinc•com, hch@infradead•org,
willy@infradead•org, willemdebruijn.kernel@gmail•com,
skhawaja@google•com, kuba@kernel•org,
Martin Karsten <mkarsten@uwaterloo•ca>,
"David S. Miller" <davem@davemloft•net>,
Simon Horman <horms@kernel•org>, Shuah Khan <shuah@kernel•org>,
open list <linux-kernel@vger•kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger•kernel.org>
Subject: Re: [PATCH net-next v6 6/7] selftests: net: Add busy_poll_test
Date: Tue, 5 Nov 2024 09:49:33 -0800 [thread overview]
Message-ID: <ZyparShLqRVi69ed@LQ3V64L9R2> (raw)
In-Reply-To: <ZymV_dgbVKW49595@mini-arch>
On Mon, Nov 04, 2024 at 07:50:21PM -0800, Stanislav Fomichev wrote:
> On 11/04, Joe Damato wrote:
> > Add an epoll busy poll test using netdevsim.
> >
> > This test is comprised of:
> > - busy_poller (via busy_poller.c)
> > - busy_poll_test.sh which loads netdevsim, sets up network namespaces,
> > and runs busy_poller to receive data and socat to send data.
> >
> > The selftest tests two different scenarios:
> > - busy poll (the pre-existing version in the kernel)
> > - busy poll with suspend enabled (what this series adds)
> >
> > The data transmit is a 1MiB temporary file generated from /dev/urandom
> > and the test is considered passing if the md5sum of the input file to
> > socat matches the md5sum of the output file from busy_poller.
> >
> > netdevsim was chosen instead of veth due to netdevsim's support for
> > netdev-genl.
> >
> > For now, this test uses the functionality that netdevsim provides. In the
> > future, perhaps netdevsim can be extended to emulate device IRQs to more
> > thoroughly test all pre-existing kernel options (like defer_hard_irqs)
> > and suspend.
> >
> > Signed-off-by: Joe Damato <jdamato@fastly•com>
> > Co-developed-by: Martin Karsten <mkarsten@uwaterloo•ca>
> > Signed-off-by: Martin Karsten <mkarsten@uwaterloo•ca>
> > ---
[...]
> > +
> > +static void run_poller(void)
> > +{
> > + struct epoll_event events[cfg_max_events];
> > + struct epoll_params epoll_params = {0};
> > + struct sockaddr_in server_addr;
> > + int i, epfd, nfds;
> > + ssize_t readlen;
> > + int outfile_fd;
> > + char buf[1024];
> > + int sockfd;
> > + int conn;
> > + int val;
>
> [..]
>
> > + outfile_fd = open(cfg_outfile, O_WRONLY | O_CREAT, 0644);
> > + if (outfile_fd == -1)
> > + error(1, errno, "unable to open outfile: %s", cfg_outfile);
>
> Any reason you're not printing to stdout? And then redirect it to a file
> in the shell script if needed. Lets you save some code on open/close
> and flag parsing :-p But I guess can keep it since you already have it
> all working.
No reason in particular; I thought about this while writing it, but
ended up adding it as a flag in case others come along to extend
this test in some capacity.
> Acked-by: Stanislav Fomichev <sdf@fomichev•me>
Thanks for the ack!
next prev parent reply other threads:[~2024-11-05 17:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 21:55 [PATCH net-next v6 0/7] Suspend IRQs during application busy periods Joe Damato
2024-11-04 21:55 ` [PATCH net-next v6 1/7] net: Add napi_struct parameter irq_suspend_timeout Joe Damato
2024-11-04 21:55 ` [PATCH net-next v6 2/7] net: Suspend softirq when prefer_busy_poll is set Joe Damato
2024-11-06 5:03 ` Jakub Kicinski
2024-11-06 16:52 ` Joe Damato
2024-11-06 23:31 ` Jakub Kicinski
2024-11-07 3:24 ` Joe Damato
2024-11-07 21:01 ` Joe Damato
2024-11-08 3:52 ` Jakub Kicinski
2024-11-04 21:55 ` [PATCH net-next v6 3/7] net: Add control functions for irq suspension Joe Damato
2024-11-04 21:55 ` [PATCH net-next v6 4/7] eventpoll: Trigger napi_busy_loop, if prefer_busy_poll is set Joe Damato
2024-11-04 21:55 ` [PATCH net-next v6 5/7] eventpoll: Control irq suspension for prefer_busy_poll Joe Damato
2024-11-04 21:55 ` [PATCH net-next v6 6/7] selftests: net: Add busy_poll_test Joe Damato
2024-11-05 3:50 ` Stanislav Fomichev
2024-11-05 17:49 ` Joe Damato [this message]
2024-11-04 21:55 ` [PATCH net-next v6 7/7] docs: networking: Describe irq suspension Joe Damato
2024-11-05 1:12 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyparShLqRVi69ed@LQ3V64L9R2 \
--to=jdamato@fastly$(echo .)com \
--cc=amritha.nambiar@intel$(echo .)com \
--cc=bagasdotme@gmail$(echo .)com \
--cc=bjorn@rivosinc$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hch@infradead$(echo .)org \
--cc=hdanton@sina$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=m2shafiei@uwaterloo$(echo .)ca \
--cc=mkarsten@uwaterloo$(echo .)ca \
--cc=namangulati@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=peter@typeblog$(echo .)net \
--cc=sdf@fomichev$(echo .)me \
--cc=shuah@kernel$(echo .)org \
--cc=skhawaja@google$(echo .)com \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=stfomichev@gmail$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
--cc=willy@infradead$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox