From: Nikolay Aleksandrov <razor@blackwall•org>
To: Kuniyuki Iwashima <kuniyu@amazon•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Simon Horman <horms@kernel•org>,
Andrew Lunn <andrew+netdev@lunn•ch>,
Marc Kleine-Budde <mkl@pengutronix•de>,
Vincent Mailhol <mailhol.vincent@wanadoo•fr>,
Daniel Borkmann <daniel@iogearbox•net>,
Kuniyuki Iwashima <kuni1840@gmail•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH v2 net-next 6/7] rtnetlink: Convert RTM_NEWLINK to per-netns RTNL.
Date: Wed, 6 Nov 2024 12:40:11 +0200 [thread overview]
Message-ID: <ZytHi46t3kbDKUBK@penguin> (raw)
In-Reply-To: <20241106022432.13065-7-kuniyu@amazon.com>
On Tue, Nov 05, 2024 at 06:24:31PM -0800, Kuniyuki Iwashima wrote:
> Now, we are ready to convert rtnl_newlink() to per-netns RTNL;
> rtnl_link_ops is protected by SRCU and netns is prefetched in
> rtnl_newlink().
>
> Let's register rtnl_newlink() with RTNL_FLAG_DOIT_PERNET and
> push RTNL down as rtnl_nets_lock().
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon•com>
> Reviewed-by: Eric Dumazet <edumazet@google•com>
> ---
> v2: Remove __rtnl_unlock() dance in rtnl_newlink().
> ---
> net/core/rtnetlink.c | 27 ++++++++++++++++++++++++---
> 1 file changed, 24 insertions(+), 3 deletions(-)
>
Reviewed-by: Nikolay Aleksandrov <razor@blackwall•org>
next prev parent reply other threads:[~2024-11-06 10:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 2:24 [PATCH v2 net-next 0/7] rtnetlink: Convert rtnl_newlink() to per-netns RTNL Kuniyuki Iwashima
2024-11-06 2:24 ` [PATCH v2 net-next 1/7] rtnetlink: Introduce struct rtnl_nets and helpers Kuniyuki Iwashima
2024-11-06 10:36 ` Nikolay Aleksandrov
2024-11-06 2:24 ` [PATCH v2 net-next 2/7] rtnetlink: Add peer_type in struct rtnl_link_ops Kuniyuki Iwashima
2024-11-06 10:37 ` Nikolay Aleksandrov
2024-11-06 2:24 ` [PATCH v2 net-next 3/7] veth: Set VETH_INFO_PEER to veth_link_ops.peer_type Kuniyuki Iwashima
2024-11-06 10:38 ` Nikolay Aleksandrov
2024-11-06 2:24 ` [PATCH v2 net-next 4/7] vxcan: Set VXCAN_INFO_PEER to vxcan_link_ops.peer_type Kuniyuki Iwashima
2024-11-06 10:38 ` Nikolay Aleksandrov
2024-11-06 2:24 ` [PATCH v2 net-next 5/7] netkit: Set IFLA_NETKIT_PEER_INFO to netkit_link_ops.peer_type Kuniyuki Iwashima
2024-11-06 10:39 ` Nikolay Aleksandrov
2024-11-06 2:24 ` [PATCH v2 net-next 6/7] rtnetlink: Convert RTM_NEWLINK to per-netns RTNL Kuniyuki Iwashima
2024-11-06 9:00 ` Paolo Abeni
2024-11-06 16:32 ` Kuniyuki Iwashima
2024-11-06 10:40 ` Nikolay Aleksandrov [this message]
2024-11-06 2:24 ` [PATCH v2 net-next 7/7] rtnetlink: Register rtnl_dellink() and rtnl_setlink() with RTNL_FLAG_DOIT_PERNET_WIP Kuniyuki Iwashima
2024-11-06 10:41 ` Nikolay Aleksandrov
2024-11-06 14:25 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZytHi46t3kbDKUBK@penguin \
--to=razor@blackwall$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kuni1840@gmail$(echo .)com \
--cc=kuniyu@amazon$(echo .)com \
--cc=mailhol.vincent@wanadoo$(echo .)fr \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox