Subject: Re: [PATCH net-next v11 06/23] ovpn: introduce the ovpn_peer object

From: Sabrina Dubroca <[email-masked]>
Date: Wed, 20 Nov 2024 12:56:52 +0100

2024-10-29, 11:47:19 +0100, Antonio Quartulli wrote:
> +/**
> + * struct ovpn_peer - the main remote peer object
> + * @ovpn: main openvpn instance this peer belongs to
> + * @id: unique identifier
> + * @vpn_addrs: IP addresses assigned over the tunnel
> + * @vpn_addrs.ipv4: IPv4 assigned to peer on the tunnel
> + * @vpn_addrs.ipv6: IPv6 assigned to peer on the tunnel
> + * @dst_cache: cache for dst_entry used to send to peer
> + * @bind: remote peer binding
> + * @halt: true if ovpn_peer_mark_delete was called

nit: It's initialized to false in ovpn_peer_new, but then never set to
true nor read. Drop it?

> + * @delete_reason: why peer was deleted (i.e. timeout, transport error, ..)
> + * @lock: protects binding to peer (bind)

nit: as well as the keepalive values that are introduced later?
(I guess the comment should be fixed up in patch 15 when the keepalive
mechanism is added)

-- 
Sabrina