From: Jiri Pirko <jiri@resnulli•us>
To: Tariq Toukan <tariqt@nvidia•com>
Cc: "David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Eric Dumazet <edumazet@google•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
netdev@vger•kernel.org, Saeed Mahameed <saeedm@nvidia•com>,
Gal Pressman <gal@nvidia•com>,
Leon Romanovsky <leonro@nvidia•com>,
Carolina Jubran <cjubran@nvidia•com>,
Cosmin Ratiu <cratiu@nvidia•com>
Subject: Re: [PATCH net-next 3/8] devlink: Extend devlink rate API with traffic classes bandwidth management
Date: Thu, 14 Nov 2024 10:48:40 +0100 [thread overview]
Message-ID: <ZzXHeDlsshYCeu73@nanopsycho.orion> (raw)
In-Reply-To: <20241113180034.714102-4-tariqt@nvidia.com>
Wed, Nov 13, 2024 at 07:00:28PM CET, tariqt@nvidia•com wrote:
>From: Carolina Jubran <cjubran@nvidia•com>
>
>Introduce support for specifying bandwidth proportions between traffic
>classes (TC) in the devlink-rate API. This new option allows users to
>allocate bandwidth across multiple traffic classes in a single command.
>
>This feature provides a more granular control over traffic management,
>especially for scenarios requiring Enhanced Transmission Selection.
>
>Users can now define a specific bandwidth share for each traffic class,
>such as allocating 20% for TC0 (TCP/UDP) and 80% for TC5 (RoCE).
>
>Example:
>DEV=pci/0000:08:00.0
>
>$ devlink port function rate add $DEV/vfs_group tx_share 10Gbit \
> tx_max 50Gbit tc-bw 0:20 1:0 2:0 3:0 4:0 5:80 6:0 7:0
>
>$ devlink port function rate set $DEV/vfs_group \
> tc-bw 0:20 1:0 2:0 3:0 4:0 5:10 6:60 7:0
>
>Signed-off-by: Carolina Jubran <cjubran@nvidia•com>
>Reviewed-by: Cosmin Ratiu <cratiu@nvidia•com>
>Signed-off-by: Tariq Toukan <tariqt@nvidia•com>
>---
> Documentation/netlink/specs/devlink.yaml | 50 ++++++++++++++++++++
> include/net/devlink.h | 6 +++
> include/uapi/linux/devlink.h | 10 ++++
> net/devlink/netlink_gen.c | 21 +++++++--
> net/devlink/netlink_gen.h | 1 +
> net/devlink/rate.c | 60 ++++++++++++++++++++++--
> 6 files changed, 141 insertions(+), 7 deletions(-)
>
>diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml
>index 09fbb4c03fc8..41fdc2514f69 100644
>--- a/Documentation/netlink/specs/devlink.yaml
>+++ b/Documentation/netlink/specs/devlink.yaml
>@@ -817,6 +817,34 @@ attribute-sets:
> -
> name: rate-tx-weight
> type: u32
>+ -
>+ name: rate-tc-0-bw
>+ type: u32
>+ -
>+ name: rate-tc-1-bw
>+ type: u32
>+ -
>+ name: rate-tc-2-bw
>+ type: u32
>+ -
>+ name: rate-tc-3-bw
>+ type: u32
>+ -
>+ name: rate-tc-4-bw
>+ type: u32
>+ -
>+ name: rate-tc-5-bw
>+ type: u32
>+ -
>+ name: rate-tc-6-bw
>+ type: u32
>+ -
>+ name: rate-tc-7-bw
>+ type: u32
This is very odd to embed index into name of attribute. Please don't do
that. Could you please separate that and have rate-tc-index as a separate
attr?
>+ -
>+ name: rate-tc-bw
>+ type: nest
>+ nested-attributes: dl-rate-tc-bw-values
[...]
next prev parent reply other threads:[~2024-11-14 9:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 18:00 [PATCH net-next 0/8] net/mlx5: ConnectX-8 SW Steering + Rate management on traffic classes Tariq Toukan
2024-11-13 18:00 ` [PATCH net-next 1/8] net/mlx5: DR, expand SWS STE callbacks and consolidate common structs Tariq Toukan
2024-11-13 18:00 ` [PATCH net-next 2/8] net/mlx5: DR, add support for ConnectX-8 steering Tariq Toukan
2024-11-13 18:00 ` [PATCH net-next 3/8] devlink: Extend devlink rate API with traffic classes bandwidth management Tariq Toukan
2024-11-13 23:22 ` kernel test robot
2024-11-14 0:05 ` kernel test robot
2024-11-14 0:46 ` kernel test robot
2024-11-14 9:48 ` Jiri Pirko [this message]
2024-11-13 18:00 ` [PATCH net-next 4/8] net/mlx5:Add no-op implementation for setting tc-bw on rate objects Tariq Toukan
2024-11-13 18:00 ` [PATCH net-next 5/8] net/mlx5: Add support for new scheduling elements Tariq Toukan
2024-11-13 18:00 ` [PATCH net-next 6/8] net/mlx5: Add support for setting tc-bw on nodes Tariq Toukan
2024-11-13 18:00 ` [PATCH net-next 7/8] net/mlx5: Add traffic class scheduling support for vport QoS Tariq Toukan
2024-11-13 18:00 ` [PATCH net-next 8/8] net/mlx5: Manage TC arbiter nodes and provide full support for tc-bw Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzXHeDlsshYCeu73@nanopsycho.orion \
--to=jiri@resnulli$(echo .)us \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=cjubran@nvidia$(echo .)com \
--cc=cratiu@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leonro@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox