Subject: Re: [PATCH net-next v2 8/8] ethtool: regenerate uapi header from the spec

From: Stanislav Fomichev <[email-masked]>
Date: Fri, 15 Nov 2024 13:56:44 -0800

On 11/15, Jakub Kicinski wrote:
> On Fri, 15 Nov 2024 11:36:46 -0800 Stanislav Fomichev wrote:
> > +/**
> > + * enum ethtool_header_flags
> > + * @ETHTOOL_FLAG_COMPACT_BITSETS: use compact bitsets in reply
> > + * @ETHTOOL_FLAG_OMIT_REPLY: provide optional reply for SET or ACT requests
> > + * @ETHTOOL_FLAG_STATS: request statistics, if supported by the driver
> > + */
> 
> Looks like we need a doc on the enum itself here:
> 
> include/uapi/linux/ethtool_netlink_generated.h:23: warning: missing initial short description on line:
>  * enum ethtool_header_flags

"Assorted ethtool flags" as placeholder? Any better ideas? These don't seem
to have a good common purpose :-(