From: David Ahern <dsahern@kernel•org>
To: Petr Machata <petrm@nvidia•com>, netdev@vger•kernel.org
Cc: "David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Ido Schimmel <idosch@nvidia•com>
Subject: Re: [PATCH net-next] net: rtnetlink: rtnl_stats_get(): Emit an extack for unset filter_mask
Date: Wed, 16 Feb 2022 08:10:49 -0700 [thread overview]
Message-ID: <a4791b77-fe00-85a2-5259-e79e8be511c5@kernel.org> (raw)
In-Reply-To: <01feb1f4bbd22a19f6629503c4f366aed6424567.1645020876.git.petrm@nvidia.com>
On 2/16/22 7:31 AM, Petr Machata wrote:
> Both get and dump handlers for RTM_GETSTATS require that a filter_mask, a
> mask of which attributes should be emitted in the netlink response, is
> unset. rtnl_stats_dump() does include an extack in the bounce,
> rtnl_stats_get() however does not. Fix the omission.
>
> Signed-off-by: Petr Machata <petrm@nvidia•com>
> Reviewed-by: Ido Schimmel <idosch@nvidia•com>
> ---
> net/core/rtnetlink.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@kernel•org>
next prev parent reply other threads:[~2022-02-16 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 14:31 [PATCH net-next] net: rtnetlink: rtnl_stats_get(): Emit an extack for unset filter_mask Petr Machata
2022-02-16 15:10 ` David Ahern [this message]
2022-02-17 5:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4791b77-fe00-85a2-5259-e79e8be511c5@kernel.org \
--to=dsahern@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=idosch@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=petrm@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox