From: Alexander Lobakin <aleksander.lobakin@intel•com>
To: Tony Nguyen <anthony.l.nguyen@intel•com>
Cc: Arnd Bergmann <arnd@kernel•org>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Arnd Bergmann <arnd@arndb•de>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
Paolo Abeni <pabeni@redhat•com>,
Alan Brady <alan.brady@intel•com>,
Sridhar Samudrala <sridhar.samudrala@intel•com>,
Willem de Bruijn <willemb@google•com>,
Phani Burra <phani.r.burra@intel•com>,
Joshua Hay <joshua.a.hay@intel•com>,
Pavan Kumar Linga <pavan.kumar.linga@intel•com>,
Madhu Chittim <madhu.chittim@intel•com>,
<intel-wired-lan@lists•osuosl.org>, <netdev@vger•kernel.org>,
<linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] idpf: fix building without IPv4
Date: Wed, 4 Oct 2023 10:50:54 +0200 [thread overview]
Message-ID: <a714593b-32a3-d552-e435-76e4a5dbb951@intel.com> (raw)
In-Reply-To: <1430f3d3-4e84-b0ec-acd9-8a51db178f73@intel.com>
From: Tony Nguyen <anthony.l.nguyen@intel•com>
Date: Mon, 25 Sep 2023 10:05:03 -0700
>
> On 9/25/2023 8:58 AM, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb•de>
>>
>> The newly added offload code fails to link when IPv4 networking is
>> disabled:
>>
>> arm-linux-gnueabi-ld: drivers/net/ethernet/intel/idpf/idpf_txrx.o: in
>> function `idpf_vport_splitq_napi_poll':
>> idpf_txrx.c:(.text+0x7a20): undefined reference to `tcp_gro_complete'
>>
>> Add complile-time checks for both CONFIG_INET (ipv4) and CONFIG_IPV6
>> in order to drop the corresponding code when the features are
>> unavailable.
>> This should also help produce slightly better output for IPv4-only
>> kernel builds, if anyone still uses those.
>
> Hi Arnd,
>
> Also, a pending patch for this [1], however, this does look a bit more
I agree Arnd's version is more efficient, the other question is why my
patch has been hanging in your tree for 2 weeks, although I asked to
take it directly to fix automated builds ASAP xD
> efficient. Adding Olek as he's author on the other patch.
>
> netdev maintainers,
>
> If this is the version that does get picked up, did you want to take it
> directly to close out the compile issues?
[...]
Thanks,
Olek
prev parent reply other threads:[~2023-10-04 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 15:58 [PATCH] idpf: fix building without IPv4 Arnd Bergmann
2023-09-25 17:05 ` Tony Nguyen
2023-10-03 22:43 ` Jakub Kicinski
2023-10-04 8:25 ` Arnd Bergmann
2023-10-04 8:50 ` Alexander Lobakin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a714593b-32a3-d552-e435-76e4a5dbb951@intel.com \
--to=aleksander.lobakin@intel$(echo .)com \
--cc=alan.brady@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=arnd@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=joshua.a.hay@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=madhu.chittim@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.kumar.linga@intel$(echo .)com \
--cc=phani.r.burra@intel$(echo .)com \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox