From: John Fastabend <john.fastabend@gmail•com>
To: Pablo Neira Ayuso <pablo@netfilter•org>, netdev@vger•kernel.org
Cc: davem@davemloft•net, thomas.lendacky@amd•com,
f.fainelli@gmail•com, ariel.elior@cavium•com,
michael.chan@broadcom•com, santosh@chelsio•com,
madalin.bucur@nxp•com, yisen.zhuang@huawei•com,
salil.mehta@huawei•com, jeffrey.t.kirsher@intel•com,
tariqt@mellanox•com, saeedm@mellanox•com, jiri@mellanox•com,
idosch@mellanox•com, jakub.kicinski@netronome•com,
peppe.cavallaro@st•com, grygorii.strashko@ti•com, andrew@lunn•ch,
vivien.didelot@savoirfairelinux•com, alexandre.torgue@st•com,
joabreu@synopsys•com, linux-net-drivers@solarflare•com,
ganeshgr@chelsio•com, ogerlitz@mellanox•com,
Manish.Chopra@cavium•com, marcelo.leitner@gmail•com
Subject: Re: [PATCH net-next,v4 00/12] add flow_rule infrastructure
Date: Thu, 29 Nov 2018 07:47:07 -0800 [thread overview]
Message-ID: <a90fed1e-fa40-5047-e618-325487f7319e@gmail.com> (raw)
In-Reply-To: <20181129022231.2740-1-pablo@netfilter.org>
On 11/28/18 6:22 PM, Pablo Neira Ayuso wrote:
> Hi,
>
> This patchset is another iteration to introduce an in-kernel intermediate
> representation (IR) to express ACL hardware offloads [1] [2] [3].
>
Hi,
Also wanted to add. In an earlier thread it was mentioned this could be
used for other offload rule infrastructures specifically u32 was
mentioned. I don't think this is actually possible on the flow_rule
side. This set uses basically an enum based key system where enums
such as FLOW_DISSECTOR_KEY_* identify the field in the packet. For
every field we want to match a new key is needed. But the u32 classifier
defines fields using offset/mask and a parse graph. They do not seem
compatible to me so in the end this unifies ethtool and flower only.
Did I get this right?
So would it be better to simply map ethtool onto flower vs defining
a new one? Patch 1 seems to be pretty light-weight so maybe rather
than calling it a new IR we just need some helper routines for
drivers to work with.
Probably a more detailed cover letter explaining motivation
and any future work would help (me at least) understand the direction.
I see netfilter offload was mentioned at one point so maybe that is
the motivation that makes it more clear why flower API today is
insufficient. Mostly curious at this point I see Jiri and Florian
both reviewed it already.
Thanks,
John
next prev parent reply other threads:[~2018-11-30 2:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 2:22 [PATCH net-next,v4 00/12] add flow_rule infrastructure Pablo Neira Ayuso
2018-11-29 2:22 ` [PATCH net-next,v4 01/12] flow_offload: add flow_rule and flow_match structures and use them Pablo Neira Ayuso
2018-11-29 2:22 ` [PATCH net-next,v4 02/12] net/mlx5e: support for two independent packet edit actions Pablo Neira Ayuso
2018-11-29 2:22 ` [PATCH net-next,v4 03/12] flow_offload: add flow action infrastructure Pablo Neira Ayuso
2018-11-29 2:22 ` [PATCH net-next,v4 04/12] cls_api: add translator to flow_action representation Pablo Neira Ayuso
2018-11-29 2:22 ` [PATCH net-next,v4 05/12] flow_offload: add statistics retrieval infrastructure and use it Pablo Neira Ayuso
2018-11-29 14:06 ` Venkat Duvvuru
2018-11-29 20:48 ` Jakub Kicinski
2018-12-01 9:55 ` Pablo Neira Ayuso
2018-11-29 2:22 ` [PATCH net-next,v4 06/12] drivers: net: use flow action infrastructure Pablo Neira Ayuso
2018-11-29 2:22 ` [PATCH net-next,v4 07/12] cls_flower: don't expose TC actions to drivers anymore Pablo Neira Ayuso
2018-11-29 2:22 ` [PATCH net-next,v4 08/12] flow_offload: add wake-up-on-lan and queue to flow_action Pablo Neira Ayuso
2018-11-29 2:22 ` [PATCH net-next,v4 09/12] ethtool: add basic ethtool_rx_flow_spec to flow_rule structure translator Pablo Neira Ayuso
2018-11-29 13:12 ` Michal Kubecek
[not found] ` <20181205131037.gznwi35tkz7pxmge@salvia>
2018-12-05 13:56 ` Michal Kubecek
2018-11-29 2:22 ` [PATCH net-next,v4 10/12] dsa: bcm_sf2: use flow_rule infrastructure Pablo Neira Ayuso
2018-11-29 2:22 ` [PATCH net-next,v4 11/12] qede: place ethtool_rx_flow_spec after code after TC flower codebase Pablo Neira Ayuso
2018-11-29 2:22 ` [PATCH net-next,v4 12/12] qede: use ethtool_rx_flow_rule() to remove duplicated parser code Pablo Neira Ayuso
2018-12-01 16:19 ` kbuild test robot
2018-11-29 15:47 ` John Fastabend [this message]
2018-11-29 16:53 ` [PATCH net-next,v4 00/12] add flow_rule infrastructure Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a90fed1e-fa40-5047-e618-325487f7319e@gmail.com \
--to=john.fastabend@gmail$(echo .)com \
--cc=Manish.Chopra@cavium$(echo .)com \
--cc=alexandre.torgue@st$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=ariel.elior@cavium$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=ganeshgr@chelsio$(echo .)com \
--cc=grygorii.strashko@ti$(echo .)com \
--cc=idosch@mellanox$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=madalin.bucur@nxp$(echo .)com \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=pablo@netfilter$(echo .)org \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=saeedm@mellanox$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=santosh@chelsio$(echo .)com \
--cc=tariqt@mellanox$(echo .)com \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
--cc=yisen.zhuang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox