From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Mathew McBride <matt@traverse•com.au>
Cc: Ioana Ciornei <ioana.ciornei@nxp•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org, Andrew Lunn <andrew@lunn•ch>,
Heiner Kallweit <hkallweit1@gmail•com>,
regressions@lists•linux.dev
Subject: Re: [REGRESSION] net: pcs-lynx: 10G SFP no longer links up
Date: Tue, 22 Apr 2025 17:03:45 +0100 [thread overview]
Message-ID: <aAe94Tkf-IYjswfP@shell.armlinux.org.uk> (raw)
In-Reply-To: <025c0ebe-5537-4fa3-b05a-8b835e5ad317@app.fastmail.com>
On Fri, Apr 18, 2025 at 01:02:19PM +1000, Mathew McBride wrote:
> #regzbot introduced: 6561f0e547be221f411fda5eddfcc5bd8bb058a5
>
> Hi Russell,
>
> On Thu, Dec 5, 2024, at 8:42 PM, Russell King (Oracle) wrote:
> > Report the PCS in-band capabilities to phylink for the Lynx PCS.
> >
>
> The implementation of in-band capabilities has broken SFP+ (10GBase-R) mode on my LS1088 board.
> The other ports in the system (QSGMII) work fine.
Thanks for the report.
Please try the diff below:
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 1bdd5d8bb5b0..2147e2d3003a 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -3624,6 +3624,15 @@ static int phylink_sfp_config_optical(struct phylink *pl)
phylink_dbg(pl, "optical SFP: chosen %s interface\n",
phy_modes(interface));
+ /* GBASE-R interfaces with the exception of KR do not have autoneg at
+ * the PCS. As the PCS is media facing, disable the Autoneg bit in the
+ * advertisement.
+ */
+ if (interface == PHY_INTERFACE_MODE_5GBASER ||
+ interface == PHY_INTERFACE_MODE_10GBASER ||
+ interface == PHY_INTERFACE_MODE_25GBASER)
+ __clear_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, config.advertising);
+
if (!phylink_validate_pcs_inband_autoneg(pl, interface,
config.advertising)) {
phylink_err(pl, "autoneg setting not compatible with PCS");
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-04-22 16:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 9:42 [PATCH net-next 0/3] net: net: add negotiation of in-band capabilities (remainder) Russell King (Oracle)
2024-12-05 9:42 ` [PATCH net-next 1/3] net: pcs: pcs-lynx: implement pcs_inband_caps() method Russell King (Oracle)
2025-04-18 3:02 ` [REGRESSION] net: pcs-lynx: 10G SFP no longer links up Mathew McBride
2025-04-22 16:03 ` Russell King (Oracle) [this message]
2025-04-23 9:01 ` Mathew McBride
2025-07-10 5:29 ` Mathew McBride
2025-08-12 12:17 ` Thorsten Leemhuis
2025-08-12 16:42 ` Russell King (Oracle)
2025-08-15 10:18 ` Russell King (Oracle)
2025-08-18 9:59 ` Mathew McBride
2025-07-13 15:02 ` [PATCH net-next 1/3] net: pcs: pcs-lynx: implement pcs_inband_caps() method Josua Mayer
2024-12-05 9:42 ` [PATCH net-next 2/3] net: pcs: pcs-mtk-lynxi: " Russell King (Oracle)
2024-12-08 3:01 ` Daniel Golle
2024-12-08 9:13 ` Russell King (Oracle)
2025-01-02 12:26 ` Daniel Golle
2025-01-03 10:55 ` Russell King (Oracle)
2024-12-17 7:49 ` Eric Woudstra
2025-01-02 8:59 ` Russell King (Oracle)
2025-01-02 12:32 ` Daniel Golle
2024-12-05 9:42 ` [PATCH net-next 3/3] net: pcs: xpcs: " Russell King (Oracle)
2024-12-08 2:00 ` [PATCH net-next 0/3] net: net: add negotiation of in-band capabilities (remainder) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAe94Tkf-IYjswfP@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=matt@traverse$(echo .)com.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=regressions@lists$(echo .)linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox